Merge pull request #6322 from christianbeeznest/ofaj-22651

christianbeeznest · web-flow · commit 6dc61af651ed · 2025-05-29T18:17:38.000-05:00
User: Prevent type error in hasAuthSourceByAuthentication() - refs BT#22651
diff --git a/src/CoreBundle/Entity/User.php b/src/CoreBundle/Entity/User.php
@@ -2483,9 +2483,11 @@ public function addAuthSourceByAuthentication(string $authentication, AccessUrl
 
     public function hasAuthSourceByAuthentication(string $authentication): bool
     {
-        return $this->authSources
-            ->exists(fn (UserAuthSource $authSource) => $authSource->getAuthentication() === $authentication)
-        ;
+        return $this->authSources->exists(
+            fn ($key, $authSource) =>
+                $authSource instanceof UserAuthSource &&
+                $authSource->getAuthentication() === $authentication
+        );
     }
 
     public function getAuthSourceByAuthentication(string $authentication): UserAuthSource

Original file line number	Diff line number	Diff line change
`@@ -2483,9 +2483,11 @@ public function addAuthSourceByAuthentication(string $authentication, AccessUrl`
`2483`	`2483`
`2484`	`2484`	`public function hasAuthSourceByAuthentication(string $authentication): bool`
`2485`	`2485`	`{`
`2486`		`- return $this->authSources`
`2487`		`- ->exists(fn (UserAuthSource $authSource) => $authSource->getAuthentication() === $authentication)`
`2488`		`- ;`
	`2486`	`+ return $this->authSources->exists(`
	`2487`	`+ fn ($key, $authSource) =>`
	`2488`	`+ $authSource instanceof UserAuthSource &&`
	`2489`	`+ $authSource->getAuthentication() === $authentication`
	`2490`	`+ );`
`2489`	`2491`	`}`
`2490`	`2492`
`2491`	`2493`	`public function getAuthSourceByAuthentication(string $authentication): UserAuthSource`