TypeError: Attempted to assign to readonly property. after upgrading to React 19

[caseybaggz]

Hello 👋

I'm in the process of updating our Design System which uses PandaCSS & Ark to React 19 and notice we have quite a few test failures now that look like they stem from some zag APIs here and there?

Here is an example:

✓ Tooltip > should render a tooltip element [22.06ms]
70 |     return;
71 |   }
72 |   const win = getWindow(root);
73 |   const doc = getDocument(root);
74 |   let focus = win.HTMLElement.prototype.focus;
75 |   win.HTMLElement.prototype.focus = function() {
                       ^
TypeError: Attempted to assign to readonly property.
      at setupGlobalFocusEvents (/Users/X/github/cerberus/node_modules/.pnpm/@[email protected]/node_modules/@zag-js/focus-visible/dist/index.mjs:75:19)
      at trackFocusVisible (/Users/X/github/cerberus/node_modules/.pnpm/@[email protected]/node_modules/@zag-js/focus-visible/dist/index.mjs:149:3)
      at effect (/Users/X/github/cerberus/node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@zag-js/react/dist/index.mjs:189:23)
      at onChange (/Users/X/github/cerberus/node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@zag-js/react/dist/index.mjs:230:26)
      at invoke (/Users/X/github/cerberus/node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@zag-js/react/dist/index.mjs:51:15)
      at <anonymous> (/Users/X/github/cerberus/node_modules/.pnpm/@[email protected][email protected][email protected][email protected]/node_modules/@zag-js/react/dist/index.mjs:240:13)
      at captureError (/Users/X/github/cerberus/node_modules/.pnpm/[email protected]/node_modules/happy-dom/lib/window/WindowErrorUtility.js:21:22)
      at <anonymous> (/Users/X/github/cerberus/node_modules/.pnpm/[email protected]/node_modules/happy-dom/lib/window/BrowserWindow.js:987:40)

Has anyone else come across this and found a fix? I feel like there is probably something somewhere we can improve since I'm not finding issues, etc. - but thought I would ask? 🤔

Our testing environment (the test directory in our repo) is Bun (latest) with testing-library (latest) if that helps?

[caseybaggz]

I fixed this by migrating all the tests to remove strictMode from our testing-library setup 🤔 🤷‍♀️