Skip to content

There are some <unexpected> instructions in textual semir #5384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danakj opened this issue Apr 29, 2025 · 1 comment
Open

There are some <unexpected> instructions in textual semir #5384

danakj opened this issue Apr 29, 2025 · 1 comment

Comments

@danakj
Copy link
Contributor

danakj commented Apr 29, 2025

Description of the bug:

Some instructions have snuck into our test cases. We should figure out what instructions they reference and get those instructions to be in a block that is included in formatted semir.

Example in toolchain/check/testdata/alias/fail_control_flow.carbon: https://github.com/carbon-language/carbon-lang/pull/5361/files#diff-82254f33573e9d6dcdb65434312087f4513fc2e554290ed0309575daf9174814R80

@jonmeow
Copy link
Contributor

jonmeow commented Apr 29, 2025

We should be concerned if these show up in valid code, but particularly for erroneous code, there may not be a good way to put instructions in a valid control flow that the formatter fully recognizes for naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants