Feature description
In the /normalize response for primaryCoding and mappings, it would be nice to include the source name.
|
"primaryCoding": { |
|
"id": "ncit:C4989", |
|
"code": "C4989", |
|
"system": "https://ncit.nci.nih.gov/ncitbrowser/ConceptReport.jsp?dictionary=NCI_Thesaurus&code=", |
|
}, |
Use case
In downstream applications, we use /normalize and want to use the source provided name for a given system
Acceptance Criteria
Given I'm using /normalize?q=melanoma,
When I want to see the Coding object for disease.primaryCoding,
Then I should get:
{
"id": "ncit:C3224",
"code": "C3224",
"name": "Melanoma",
"system": "https://ncit.nci.nih.gov/ncitbrowser/ConceptReport.jsp?dictionary=NCI_Thesaurus&code="
}
Given I'm using /normalize?q=melanoma,
When I want to see the MappableConcepts for disease.mappings,
Then I should get name populated in the coding.name such as one record below:
{
"coding": {
"id": "MONDO_0004355",
"code": "MONDO:0004355",
"name": "childhood leukemia",
"system": "https://purl.obolibrary.org/obo/",
},
"relation": "exactMatch"
}
Proposed solution
No response
Alternatives considered
No response
Implementation details
Unsure of what this looks like for sources we don't ingest. If that's a large lift, I think it'd be fine to focus on sources we ingest (primary coding + mappings with exact match) for now
Potential Impact
No response
Additional context
We'll probably want this in our other normalizers. I can make issues later.
Contribution
None
Feature description
In the
/normalizeresponse forprimaryCodingandmappings, it would be nice to include the source name.disease-normalization/src/disease/schemas.py
Lines 344 to 348 in b5acc14
disease-normalization/src/disease/schemas.py
Line 351 in b5acc14
Use case
In downstream applications, we use
/normalizeand want to use the source provided name for a given systemAcceptance Criteria
Given I'm using
/normalize?q=melanoma,When I want to see the
Codingobject fordisease.primaryCoding,Then I should get:
{ "id": "ncit:C3224", "code": "C3224", "name": "Melanoma", "system": "https://ncit.nci.nih.gov/ncitbrowser/ConceptReport.jsp?dictionary=NCI_Thesaurus&code=" }Given I'm using
/normalize?q=melanoma,When I want to see the
MappableConceptsfordisease.mappings,Then I should get
namepopulated in thecoding.namesuch as one record below:{ "coding": { "id": "MONDO_0004355", "code": "MONDO:0004355", "name": "childhood leukemia", "system": "https://purl.obolibrary.org/obo/", }, "relation": "exactMatch" }Proposed solution
No response
Alternatives considered
No response
Implementation details
Unsure of what this looks like for sources we don't ingest. If that's a large lift, I think it'd be fine to focus on sources we ingest (primary coding + mappings with exact match) for now
Potential Impact
No response
Additional context
We'll probably want this in our other normalizers. I can make issues later.
Contribution
None