Skip to content

Commit 219055b

Browse files
authored
fix: use 'all' for fabric components codegen config (#715)
currently codegen doesn't generate all required files such as `Android.mk`, `CMakeLists.txt` etc. for fabric when type is set to `components`. so we use `all` for now until this bug is fixed. closes #661
1 parent 34b1f80 commit 219055b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/create-react-native-library/templates/common-local/$package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<% if (project.arch !== 'legacy') { -%>
77
"codegenConfig": {
88
"name": "RN<%- project.name -%><%- project.view ? 'View': '' -%>Spec",
9-
"type": <%- project.view ? '"components"': '"modules"' %>,
9+
"type": <%- project.view ? '"all"': '"modules"' %>,
1010
"jsSrcsDir": "src"
1111
},
1212
<% } -%>

packages/create-react-native-library/templates/common/$package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@
198198
},
199199
"codegenConfig": {
200200
"name": "RN<%- project.name -%><%- project.view ? 'View': '' -%>Spec",
201-
"type": "<%- project.view ? 'components': 'modules' -%>",
201+
"type": "<%- project.view ? 'all': 'modules' -%>",
202202
"jsSrcsDir": "src",
203203
"outputDir": {
204204
"ios": "ios/generated",
@@ -209,7 +209,7 @@
209209
<% if (example === 'vanilla') { -%>
210210
},
211211
"includesGeneratedCode": true
212-
<% } else { -%>
212+
<% } else { -%>
213213
}
214214
<% } -%>
215215
<% } -%>

0 commit comments

Comments
 (0)