Skip to content

Not able to turn off recurring event and then turn on Offer seats in the same request. #21412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wokepadia opened this issue May 20, 2025 · 1 comment · May be fixed by #21413
Open

Not able to turn off recurring event and then turn on Offer seats in the same request. #21412

wokepadia opened this issue May 20, 2025 · 1 comment · May be fixed by #21413
Labels
🐛 bug Something isn't working seats area: seats, guest meetings, multiple people

Comments

@wokepadia
Copy link

Found a bug? Please fill out the sections below. 👍

Issue Summary

Recurring event and offer seats cannot be turned on at the same time, so we make sure that we don't set both to true at the same time. But if I have recurring events on, and I want to turn it off and turn on Offer seats in a single request (i.e. doing both actions and then clicking save), I get an error.

Steps to Reproduce

  1. Turn recurring events on.
  2. Click save.
  3. Turn recurring events off.
  4. Without clicking save, go and turn on Offer seats option.
  5. Click save. You will get an error: Recurring Events and Offer Seats cannot be active at the same time.

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

Actual Results

  • Error is displayed

Expected Results

  • Save operation should succeed.

Technical details

I will be sending a PR for this issue.

Evidence

  • How was this tested? This is quite mandatory in terms of bugs. Providing evidence of your testing with screenshots or/and videos is an amazing way to prove the bug and a troubleshooting chance to find the solution.
Image
@wokepadia wokepadia added the 🐛 bug Something isn't working label May 20, 2025
@linear Linear
Copy link

linear bot commented May 20, 2025

CAL-5793 Not able to turn off `recurring event` and then turn on `Offer seats` in the same request.

@dosubot dosubot bot added the seats area: seats, guest meetings, multiple people label May 20, 2025
wokepadia added a commit to wokepadia/cal.com that referenced this issue May 20, 2025
@wokepadia
fix: Do not fallback to existing db value if input is null for settings.
9168a87 
Fixes calcom#21412.
For `finalSeatsPerTimeSlot` and `finalRecurringEvent` we were falling back
to the DB value if `seatsPerTimeSlot` or `recurringEvent` was falsy. Instead,
we should only fallback to the DB value if those values are undefined.
Those values being undefined means that they have not changed, while those
values being null means they are being reset to not have any value in them.
This was causing an error when a user was trying to turn off `Recurring event`
and turn on `Offer seats` in the same event.
@wokepadia wokepadia linked a pull request May 20, 2025 that will close this issue
Draft
3 tasks
wokepadia added a commit to wokepadia/cal.com that referenced this issue May 20, 2025
@wokepadia
fix: Do not fallback to existing db value if input is null for settings.
8f4012c 
Fixes calcom#21412.
For `finalSeatsPerTimeSlot` and `finalRecurringEvent` we were falling back
to the DB value if `seatsPerTimeSlot` or `recurringEvent` was falsy. Instead,
we should only fallback to the DB value if those values are undefined.
Those values being undefined means that they have not changed, while those
values being null means they are being reset to not have any value in them.
This was causing an error when a user was trying to turn off `Recurring event`
and turn on `Offer seats` in the same event.
wokepadia added a commit to wokepadia/cal.com that referenced this issue May 20, 2025
@wokepadia
fix: Do not fallback to existing db value if input is null for settings.
d5b4897 
Fixes calcom#21412.
For `finalSeatsPerTimeSlot` and `finalRecurringEvent` we were falling back
to the DB value if `seatsPerTimeSlot` or `recurringEvent` was falsy. Instead,
we should only fallback to the DB value if those values are undefined.
Those values being undefined means that they have not changed, while those
values being null means they are being reset to not have any value in them.
This was causing an error when a user was trying to turn off `Recurring event`
and turn on `Offer seats` in the same event.
wokepadia added a commit to wokepadia/cal.com that referenced this issue May 21, 2025
@wokepadia
fix: Do not fallback to existing db value if input is null for settings.
c2ea37f 
Fixes calcom#21412.
For `finalSeatsPerTimeSlot` and `finalRecurringEvent` we were falling back
to the DB value if `seatsPerTimeSlot` or `recurringEvent` was falsy. Instead,
we should only fallback to the DB value if those values are undefined.
Those values being undefined means that they have not changed, while those
values being null means they are being reset to not have any value in them.
This was causing an error when a user was trying to turn off `Recurring event`
and turn on `Offer seats` in the same event.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working seats area: seats, guest meetings, multiple people
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Do not fallback to existing db value if input is null for settings. wokepadia/cal.com
1 participant
@wokepadia