Skip to content

Potential unexpected nulls #3

@colinscape

Description

@colinscape

In the line

        $ddTraceSpan = \DDTrace\GlobalTracer::get()->getActiveSpan();

I suspect it's possible for this to come back with a null, either in the call to get() or the call to getActiveSpan(), if something hasn't worked quite as expected.

I think we should be more explicit about checking these return values before we use them, else we risk some fatal errors and processes shutting down, just because of the logging - which we want to be as invisible as possible.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions