Skip to content

Commit 319ad25

Browse files
committed
Update header list. Add middleware option.
1 parent 88f9c5c commit 319ad25

File tree

4 files changed

+26
-6
lines changed

4 files changed

+26
-6
lines changed

README.md

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ app.use(logMiddleware({
6161
userId: req.session.userId,
6262
profileId: req.query.profileId,
6363
};
64-
};
64+
},
6565
}));
6666
```
6767

@@ -80,7 +80,7 @@ app.use(logMiddleware({
8080
processingTime: responseTime - req.trackingData.externalRequestTime,
8181
imagesScanned: req.trackingData.imagesScanned,
8282
};
83-
};
83+
},
8484
}));
8585
// In your request handler
8686
app.get('/get-images', (req, res) => {
@@ -91,3 +91,13 @@ app.get('/get-images', (req, res) => {
9191
});
9292
});
9393
```
94+
95+
#### Params
96+
97+
Add logging of specific query string params using the `getMetadata` option.
98+
99+
```js
100+
app.use(logMiddleware({
101+
params: ['profile_id', 'utm_campaign'],
102+
}));
103+
```

lib/utils.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,12 @@ module.exports.pick = pick;
5656

5757

5858
const headersToLog = [
59-
'user-agent',
60-
'referer',
6159
'cache-control',
60+
'host',
61+
'referer',
62+
'user-agent',
63+
'x-real-ip',
64+
'x-forwarded-for',
6265
];
6366
/**
6467
* getRequestDataToLog

middleware.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,12 @@ module.exports = function middleware(options) {
1414
const {
1515
getMetadata,
1616
getStats,
17+
params,
1718
} = options;
1819

1920
return function logRequest(req, res, next) {
2021
const startTime = new Date();
21-
const request = getRequestDataToLog(req);
22+
const request = getRequestDataToLog(req, params);
2223

2324
onFinished(res, () => {
2425
const finishTime = new Date();

test/testUtils.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,17 +77,23 @@ describe('utils', () => {
7777
remotePort: 40234,
7878
},
7979
headers: {
80+
host: 'buffer.com',
8081
'user-agent': 'Mozilla/5.0',
8182
referer: 'https://twitter.com',
8283
'cache-control': 'no-cache',
84+
'x-real-ip': '172.18.0.1',
85+
'x-forwarded-for': '172.18.0.1',
8386
'x-something-bogus': false,
84-
}
87+
},
8588
};
8689
const data = getRequestDataToLog(req);
8790
assert.deepEqual(data.headers, {
91+
host: 'buffer.com',
8892
'user-agent': 'Mozilla/5.0',
8993
referer: 'https://twitter.com',
9094
'cache-control': 'no-cache',
95+
'x-real-ip': '172.18.0.1',
96+
'x-forwarded-for': '172.18.0.1',
9197
});
9298
});
9399

0 commit comments

Comments
 (0)