added specs for response checks

Author: roshan04

test/unit/bin/helpers/capabilityHelper.js

@@ -779,70 +779,6 @@ describe("capabilityHelper.js", () => {
       });
     });
 
-    describe("validates username and password" , () =>{
-      beforeEach(() => {
-        //Stub for cypress json validation
-        sinon.stub(fs, 'existsSync').returns(true);
-        sinon.stub(fs, 'readFileSync').returns("{}");
-
-        bsConfig = {
-          auth: {},
-          browsers: [
-            {
-              browser: "chrome",
-              os: "Windows 10",
-              versions: ["78", "77"],
-            },
-          ],
-          run_settings: {
-            cypress_proj_dir: "random path",
-            cypressConfigFilePath: "random path"
-          },
-        };
-      });
-
-      afterEach(() => {
-        fs.existsSync.restore();
-        fs.readFileSync.restore();
-      });
-
-      it('throws an error if the user has given username as null', () =>{
-        return capabilityHelper
-          .validate(bsConfig, { username: "" })
-          .then(function (data) {
-            chai.assert.fail("Promise error");
-          })
-          .catch((error) => {
-            chai.assert.equal(error, Constants.validationMessages.EMPTY_ARGS.replace("<argsNotGiven>","Username"));
-          });
-      });
-
-      it('throws an error if the user has given password as null', () =>{
-        return capabilityHelper
-          .validate(bsConfig, { key: "" })
-          .then(function (data) {
-            chai.assert.fail("Promise error");
-          })
-          .catch((error) => {
-            chai.assert.equal(error, Constants.validationMessages.EMPTY_ARGS.replace("<argsNotGiven>","Password"));
-          });
-      });
-
-      it('throws an error if the user has given username and password both as null', () =>{
-        return capabilityHelper
-          .validate(bsConfig, {
-            username: "",
-            key: ""
-        })
-          .then(function (data) {
-            chai.assert.fail("Promise error");
-          })
-          .catch((error) => {
-            chai.assert.equal(error, Constants.validationMessages.EMPTY_ARGS.replace("<argsNotGiven>","Username and Password"));
-          });
-      });
-    });
-
     it("validate bsConfig", () => {
       let bsConfig = undefined;
       return capabilityHelper

test/unit/bin/helpers/zipUpload.js

@@ -55,7 +55,7 @@ describe("zipUpload", () => {
       });
   });
 
-  it("reject with error (if error present in response) if statusCode != 200", () => {
+  it("reject with error (if error present in response) if statusCode == 401", () => {
     let error = "non 200 code";
 
     let requestStub = sandbox
@@ -82,7 +82,7 @@ describe("zipUpload", () => {
       });
   });
 
-  it("reject with message if statusCode != 200 and error not in response", () => {
+  it("reject with message if statusCode == 401 and error not in response", () => {
     let requestStub = sandbox
       .stub(request, "post")
       .yields(
@@ -98,6 +98,65 @@ describe("zipUpload", () => {
       request: { post: requestStub },
     });
 
+    return zipUploader
+      .zipUpload(bsConfig, "./random_file_path")
+      .then(function (data) {
+        chai.assert.fail("Promise error");
+      })
+      .catch((error) => {
+        sinon.assert.calledOnce(requestStub);
+        sinon.assert.calledOnce(getUserAgentStub);
+        sinon.assert.calledOnce(createReadStreamStub);
+        chai.assert.equal(
+          error,
+          Constants.validationMessages.INVALID_DEFAULT_AUTH_PARAMS
+        );
+      });
+  });
+
+  it("reject with error (if error present in response) if statusCode != 200 and statusCode != 401", () => {
+    let error = "non 200 and non 401 code";
+
+    let requestStub = sandbox
+      .stub(request, "post")
+      .yields(null, { statusCode: 404 }, JSON.stringify({ error: error }));
+
+    const zipUploader = proxyquire("../../../../bin/helpers/zipUpload", {
+      "./utils": {
+        getUserAgent: getUserAgentStub,
+      },
+      request: { post: requestStub },
+    });
+
+    return zipUploader
+      .zipUpload(bsConfig, "./random_file_path")
+      .then(function (data) {
+        chai.assert.fail("Promise error");
+      })
+      .catch((error) => {
+        sinon.assert.calledOnce(requestStub);
+        sinon.assert.calledOnce(getUserAgentStub);
+        sinon.assert.calledOnce(createReadStreamStub);
+        chai.assert.equal(error, "non 200 and non 401 code");
+      });
+  });
+
+  it("reject with message if statusCode != 200 and statusCode != 401 and error not in response", () => {
+    let requestStub = sandbox
+      .stub(request, "post")
+      .yields(
+        null,
+        { statusCode: 404 },
+        JSON.stringify({ message: "random message" })
+      );
+
+    const zipUploader = proxyquire("../../../../bin/helpers/zipUpload", {
+      "./utils": {
+        getUserAgent: getUserAgentStub,
+      },
+      request: { post: requestStub },
+    });
+
     return zipUploader
       .zipUpload(bsConfig, "./random_file_path")
       .then(function (data) {