🎨 added spec for folder dir

Author: Archish27

bin/helpers/package-diff.js

@@ -1,71 +1,93 @@
-'use strict'
-const fs = require('fs')
-const path = require('path')
+"use strict";
+const fs = require("fs");
+const path = require("path");
 const logger = require("./logger").winstonLogger;
 
-exports.run = (basePath, comparePath)  => {
-    if (!basePath || !comparePath) {
-        logger.debug('Skipping package difference check.')
-    }
-
-    const base = readModules(basePath)
-    const compare = readModules(comparePath)
+exports.run = (basePath, comparePath) => {
+  if (!basePath || !comparePath) {
+    logger.debug("Skipping package difference check.");
+  }
 
-    let isDiff = false;
-    Object.keys(base.deps).forEach(baseKey => {
-        if (baseKey in compare.deps) {
-            if (base.deps[baseKey] === compare.deps[baseKey]) {
-                //ignore this check
-            } else {
-                isDiff = true;
-                return;
-            }
-        } else {
-            isDiff = true;
-            return;
-        }
-    })
+  let base;
+  let compare;
+  let isDiff = false;
+  try {
+    base = readModules(basePath);
+    compare = readModules(comparePath);
+  } catch (error) {
+    logger.debug('Unable to process package difference');
     return isDiff;
-}
-const readModules =  (location) =>  {
-    const table = {}
-  
-    // Resolve package dependencies
-    if (location.indexOf('package.json') !== -1) {
-      const data = fs.readFileSync(location.replace(':dev', ''), 'utf-8')
-      let parsed
-      try { parsed = JSON.parse(data) } catch (e) { parsed = false }
-      if (!parsed) { return }
-  
-      const depsKey = location.indexOf(':dev') !== -1 ? 'devDependencies' : 'dependencies'
-      const deps = parsed[depsKey] ? parsed[depsKey] : (parsed.dependencies || parsed.devDependencies)
+  }
 
-      Object.keys(deps).forEach(key => {
-        deps[key] = deps[key].replace(/\^|~/g, '')
-      })
-      return {
-        name: `${location} {${depsKey}}`,
-        deps,
+  Object.keys(base.deps).forEach((baseKey) => {
+    if (baseKey in compare.deps) {
+      if (base.deps[baseKey] !== compare.deps[baseKey]) {
+        isDiff = true;
+        return;
       }
+    } else {
+      isDiff = true;
+      return;
     }
-  
-    fs.readdirSync(location)
-    .filter(name => name !== '.bin')
-    .map(name => {
-        const pkg = path.join(location, name, 'package.json')
-        const exists = fs.existsSync(pkg)
-        if (!exists) { return }
+  });
+  return isDiff;
+};
+const readModules = (location) => {
+  const table = {};
 
-        const data = fs.readFileSync(pkg, 'utf-8')
-        let parsed
+  // Resolve package dependencies
+  if (location.indexOf("package.json") !== -1) {
+    const data = fs.readFileSync(location.replace(":dev", ""), "utf-8");
+    let parsed;
+    try {
+      parsed = JSON.parse(data);
+    } catch (e) {
+      parsed = false;
+    }
+    if (!parsed) {
+      return;
+    }
 
-        try { parsed = JSON.parse(data) } catch (e) { parsed = false }
-        if (!parsed) { return }
+    const depsKey =
+      location.indexOf(":dev") !== -1 ? "devDependencies" : "dependencies";
+    const deps = parsed[depsKey]
+      ? parsed[depsKey]
+      : parsed.dependencies || parsed.devDependencies;
 
-        table[name] = parsed.version
-    })
+    Object.keys(deps).forEach((key) => {
+      deps[key] = deps[key].replace(/\^|~/g, "");
+    });
     return {
+      name: `${location} {${depsKey}}`,
+      deps,
+    };
+  }
+
+  fs.readdirSync(location)
+    .filter((name) => name !== ".bin")
+    .map((name) => {
+      const pkg = path.join(location, name, "package.json");
+      const exists = fs.existsSync(pkg);
+      if (!exists) {
+        return;
+      }
+
+      const data = fs.readFileSync(pkg, "utf-8");
+      let parsed;
+
+      try {
+        parsed = JSON.parse(data);
+      } catch (e) {
+        parsed = false;
+      }
+      if (!parsed) {
+        return;
+      }
+
+      table[name] = parsed.version;
+    });
+  return {
     name: location,
     deps: table,
-}
-}
+  };
+};

test/unit/bin/helpers/utils.js

@@ -1042,6 +1042,13 @@ describe('utils', () => {
     });
   });
 
+  describe('getDirectorySize', () => {
+    it('should return size of directory', async() => {
+      expect(await utils.fetchFolderSize('/absolute/path')).to
+        .be.equal(0);
+    });
+  });
+
   describe('getLocalFlag', () => {
     it('should return false if connectionSettings is undefined', () => {
       expect(utils.getLocalFlag(undefined)).to.be.false;
@@ -1834,7 +1841,7 @@ describe('utils', () => {
   describe('setCypressTestSuiteType', () => {
 
     it('sets correct cypressTestSuiteType when cypress.json is the cypress config file ', () => {
-      bsConfig = {
+      let bsConfig = {
         run_settings: {
           cypressConfigFilePath: 'cypress.json',
         },
@@ -1846,7 +1853,7 @@ describe('utils', () => {
     });
 
     it('sets correct cypressTestSuiteType when cypress.config.js|.ts|.cjs|.mjs is the cypress config file ', () => {
-      bsConfig = {
+      let bsConfig = {
         run_settings: {
           cypressConfigFilePath: 'cypress.config.js',
         },
@@ -1880,7 +1887,7 @@ describe('utils', () => {
     });
 
     it('by default assumes that CYPRESS_V9_AND_OLDER_TYPE is the test suite type', () => {
-      bsConfig = {
+      let bsConfig = {
         run_settings: {},
       };
       utils.setCypressTestSuiteType(bsConfig);