Bug Fixes for isCypressProjDirValid. Absolute path for path.join

karanshah-browserstack · karanshah-browserstack · commit 92eecbcda578 · 2020-09-08T17:07:31.000+05:30
diff --git a/bin/helpers/utils.js b/bin/helpers/utils.js
@@ -206,7 +206,7 @@ exports.isCypressProjDirValid = (cypressProjDir, integrationFoldDir) => {
   let cypressDir = path.resolve(cypressProjDir);
   let integrationFolderDir = path.resolve(integrationFoldDir);
   if (!this.isAbsolute(integrationFoldDir)) {
-    integrationFolderDir = path.join(cypressProjDir, integrationFoldDir);
+    integrationFolderDir = path.resolve(path.join(cypressProjDir, integrationFoldDir));
   }
   if (integrationFolderDir === cypressDir) return true;
   let parentTokens = cypressDir.split("/").filter((i) => i.length);

Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ exports.isCypressProjDirValid = (cypressProjDir, integrationFoldDir) => {`
`206`	`206`	`let cypressDir = path.resolve(cypressProjDir);`
`207`	`207`	`let integrationFolderDir = path.resolve(integrationFoldDir);`
`208`	`208`	`if (!this.isAbsolute(integrationFoldDir)) {`
`209`		`- integrationFolderDir = path.join(cypressProjDir, integrationFoldDir);`
	`209`	`+ integrationFolderDir = path.resolve(path.join(cypressProjDir, integrationFoldDir));`
`210`	`210`	`}`
`211`	`211`	`if (integrationFolderDir === cypressDir) return true;`
`212`	`212`	`let parentTokens = cypressDir.split("/").filter((i) => i.length);`