Fix nil pointer access in getBpfAppState functions

This commit fixes a nil pointer dereference in getBpfAppState.

The getBpfAppState() functions now logs the state name from the found
object (appProgramList.Items[0].Name) instead of trying to access the
uninitialised r.currentAppState.Name field.

These fixes prevent panics that occurred when getBpfAppState was
called before currentAppState was initialised in the reconciliation
flow.

Signed-off-by: Andrew McDermott <[email protected]>

Author: frobware

controllers/bpfman-agent/cl_application_program.go

@@ -547,8 +547,7 @@ func (r *ClBpfApplicationReconciler) getBpfAppState(ctx context.Context) (*bpfma
 
 	switch len(appProgramList.Items) {
 	case 1:
-		// We got exactly one BpfApplicationState, so update r.currentAppState
-		r.Logger.V(1).Info("Found BpfApplicationState", "Name", r.currentAppState.Name)
+		r.Logger.V(1).Info("Found BpfApplicationState", "Name", appProgramList.Items[0].Name)
 		return &appProgramList.Items[0], nil
 	case 0:
 		// No BpfApplicationState found, so return nil

controllers/bpfman-agent/ns_application_program.go

@@ -490,8 +490,7 @@ func (r *NsBpfApplicationReconciler) getBpfAppState(ctx context.Context) (*bpfma
 
 	switch len(appProgramList.Items) {
 	case 1:
-		// We got exactly one BpfApplicationState, so update r.currentAppState
-		r.Logger.V(1).Info("Found BpfApplicationState", "Name", r.currentAppState.Name)
+		r.Logger.V(1).Info("Found BpfApplicationState", "Name", appProgramList.Items[0].Name)
 		return &appProgramList.Items[0], nil
 	case 0:
 		// No BpfApplicationState found, so return nil