Sort out conditions and scrub comments and naming

Signed-off-by: Andre Fredette <[email protected]>

Author: anfredette

TODO.md

@@ -5,27 +5,24 @@ The operator is integrated with Dave's load/attach split code.
 # Testing:
 
 - Unit tests for the agent and the operator
-- The following working samples contain all program types:
-    - config/samples/bpfman.io_v1alpha1_bpfapplication.yaml
-    - config/samples/bpfman.io_v1alpha1_clusterbpfapplication.yaml
+- All sample yamls work (except for bpfman.io_v1alpha1_test1_clusterbpfapplication.yaml which is a negative test.)
 
 # TODO:
 
 (In no particular order.)
 
-- ~~Implement Fentry/Fexit solution.~~
-- ~~Integrate with the new bpfman code with load/attach split (of course)~~
-- ~~Create a bpf.o file with all the application types for both cluster and~~
-  ~~namespace scoped BpfApplicaitons.~~
-- Review the status/condition values.  I redid most of the *ApplicationState
-  item status values, but the actual overall status is still using an existing
-  ReconcileSuccess value.
-- Review all comments and logs.
-- ~~Support namespace-scoped BPF Application CRD~~
-- ~~Support the rest of the program types.~~
-- ~~Delete old directories.~~
-- Rename cluster-scoped CRDs and structures to "Cluster*", and remove "ns" from
-  namespace-scoped CRDs and structures.
-- Make sure we have all the old sample programs covered by BpfApplication-based
-  sample programs and then delete the *Program-based ones.
-- More cleanup and testing.
+- Review all comments and logs.  There is still some BpfProgram-related wording.
+- Review cluster and namespace naming in controllers.
+- Scrub operator controller for BpfProgram-related naming.
+- Scrub logs (need to remove some and make some Info logs Debug)
+- Figure out why `k apply -f
+  config/samples/bpfman.io_v1alpha1_test1_clusterbpfapplication.yaml` works for
+  kprobe, fentry and fexit, but is rejected for the other program types.
+- Delete the "test" sample programs when I'm done using them for testing.
+- Review all the ANF-TODOs and create issues if necessary.
+- Get the bpfman examples and regression tests working (probably after)
+- Scrub logs (need to remove some and make some Info logs Debug)
+
+# TODO (After merge)
+- Possibly some of the scrubbing mentioned above.
+- Make more of the bpfman-agent controller code common.