ensure rclone is listening to the given port before trying to request noop

Author: alexandru-bagu

README.rst

@@ -139,6 +139,7 @@ Use storage on any of the many cloud providers `rclone <https://rclone.org/>`_ s
 - URL: ``rclone:remote:path``, we just prefix "rclone:" and give all to the right
   of that to rclone, see: https://rclone.org/docs/#syntax-of-remote-paths
 - implementation of this primarily depends on the specific remote.
+- rclone binary path can be set via the environment variable RCLONE_BINARY (default value: "rclone")
 
 
 Scalability

src/borgstore/backends/rclone.py

@@ -11,7 +11,6 @@
 from typing import Iterator
 import time
 import socket
-import random
 
 from ._base import BackendBase, ItemInfo, validate_name
 from .errors import (
@@ -86,6 +85,14 @@ def find_open_port(self):
             s.bind((self.HOST, 0))
             return s.getsockname()[1]
 
+    def check_port(self, port):
+        with socket.socket() as s:
+            try:
+                s.connect((self.HOST, port))
+                return True
+            except:
+                return False
+
     def open(self):
         """
         Start using the rclone server
@@ -113,6 +120,8 @@ def open(self):
             self.url = "http://%s:%d/" % (self.HOST, port)
             # Wait for rclone to start up
             try:
+                while self.process.poll() is None and not self.check_port(port):
+                    time.sleep(0.01)
                 self.noop("noop")
             except:
                 self.process.terminate()
@@ -197,6 +206,7 @@ def __exit__(self, exc_type, exc_val, exc_tb):
         return False
 
     def noop(self, value) -> None:
+        """noop request that returns back the provided value <value>"""
         return self._rpc("rc/noop", { "value": value })
 
     def mkdir(self, name: str) -> None: