introduce minor fixes after porting over the code from a specialized plugin (edgedriver)

Author: Allan Paiste

src/Analysers/PlatformAnalyser.php

@@ -5,14 +5,8 @@
  */
 namespace Vaimo\WebDriverBinaryDownloader\Analysers;
 
-class PlatformAnalyser
+class PlatformAnalyser implements \Vaimo\WebDriverBinaryDownloader\Interfaces\PlatformAnalyserInterface
 {
-    const TYPE_LINUX32 = 'linux32';
-    const TYPE_LINUX64 = 'linux64';
-    const TYPE_WIN32 = 'win32';
-    const TYPE_WIN64 = 'win64';
-    const TYPE_MAC64 = 'mac64';
-    
     public function getPlatformCode()
     {
         if (stripos(PHP_OS, 'win') === 0) {

src/Installer.php

@@ -5,7 +5,9 @@
  */
 namespace Vaimo\WebDriverBinaryDownloader;
 
-class Installer
+use Vaimo\WebDriverBinaryDownloader\Interfaces\ConfigInterface;
+
+class Installer implements \Vaimo\WebDriverBinaryDownloader\Interfaces\InstallerInterface
 {
     /**
      * @var \Composer\Composer
@@ -36,7 +38,7 @@ public function __construct(
         $this->utils = new \Vaimo\WebDriverBinaryDownloader\Installer\Utils();
     }
 
-    public function executeWithConfig(\Vaimo\WebDriverBinaryDownloader\Interfaces\ConfigInterface $pluginConfig)
+    public function executeWithConfig(ConfigInterface $pluginConfig)
     {
         $binaryDir = $this->composerRuntime->getConfig()->get('bin-dir');
 
@@ -78,7 +80,7 @@ public function executeWithConfig(\Vaimo\WebDriverBinaryDownloader\Interfaces\Co
 
         $pluginPackage = $projectAnalyser->resolvePackageForNamespace(
             $localRepository->getCanonicalPackages(),
-            __NAMESPACE__
+            get_class($pluginConfig)
         );
 
         $downloadManager = new \Vaimo\WebDriverBinaryDownloader\Installer\DownloadManager(

src/Installer/DownloadManager.php

@@ -81,7 +81,11 @@ public function downloadRelease(array $versions)
                 /** @var \Composer\Downloader\DownloaderInterface $downloader */
                 $downloader = $this->downloadManager->getDownloaderForInstalledPackage($package);
 
-                $downloader->download($package, $targetDir);
+                /**
+                 * Some downloaders have the option to mute the output, which is why 
+                 * there the third call argument.
+                 */
+                $downloader->download($package, $targetDir, false);
 
                 return $package;
             } catch (\Composer\Downloader\TransportException $exception) {

src/Interfaces/InstallerInterface.php

@@ -0,0 +1,16 @@
+<?php
+/**
+ * Copyright © Vaimo Group. All rights reserved.
+ * See LICENSE_VAIMO.txt for license details.
+ */
+namespace Vaimo\WebDriverBinaryDownloader\Interfaces;
+
+use Vaimo\WebDriverBinaryDownloader\Interfaces\ConfigInterface as Config;
+
+interface InstallerInterface
+{
+    /**
+     * @param Config $pluginConfig
+     */
+    public function executeWithConfig(Config $pluginConfig);
+}

src/Interfaces/PlatformAnalyserInterface.php

@@ -0,0 +1,25 @@
+<?php
+/**
+ * Copyright © Vaimo Group. All rights reserved.
+ * See LICENSE_VAIMO.txt for license details.
+ */
+namespace Vaimo\WebDriverBinaryDownloader\Interfaces;
+
+interface PlatformAnalyserInterface
+{
+    const TYPE_LINUX32 = 'linux32';
+    const TYPE_LINUX64 = 'linux64';
+    const TYPE_WIN32 = 'win32';
+    const TYPE_WIN64 = 'win64';
+    const TYPE_MAC64 = 'mac64';
+
+    /**
+     * @return string
+     */
+    public function getPlatformCode();
+
+    /**
+     * @return string
+     */
+    public function getPlatformName();
+}