server url must be secure (#41)

* server url must be secure

* server url must be secure wording

* server url must be secure better error handling

Author: WaciX

globalConfig.json

@@ -23,7 +23,7 @@
     "meta": {
         "name": "bitwarden_event_logs_beta",
         "restRoot": "bitwarden_event_logs",
-        "version": "1.2.0",
+        "version": "1.2.1",
         "displayName": "Bitwarden Event Logs (beta)",
         "schemaVersion": "0.0.3",
         "_uccVersion": "5.41.0"

package/appserver/static/javascript/views/app.js

@@ -70,6 +70,7 @@ define(["react", "splunkjs/splunk"], function(react, splunk_js_sdk){
               ),
             ]),
             e("h3", null, "Self-hosted Bitwarden servers may need to reconfigure their installation's URL."),
+            e("h4", null, "URLs starting with 'http://' is considered insecure and not allowed in Splunk. Please use 'https://' instead."),
             e("label", null, [
               "Server URL ",
               e("br"),

package/appserver/static/javascript/views/setup_page.js

@@ -53,6 +53,11 @@ export async function perform(splunk_js_sdk, setup_options) {
             { index: index },
         );
 
+        if (serverUrl.startsWith("http://")) {
+            throw new URIError("URLs starting with 'http://' is considered insecure and not allowed in Splunk. " +
+                "Please use 'https://' instead.");
+        }
+
         // Update script.conf
         const isBitwardenCloud = serverUrl === "https://bitwarden.com" || serverUrl === "bitwarden.com";
         const apiUrl = isBitwardenCloud ? "https://api.bitwarden.com" : serverUrl + "/api/";
@@ -73,7 +78,7 @@ export async function perform(splunk_js_sdk, setup_options) {
         await Config.reload_splunk_app(service, app_name);
         Config.redirect_to_splunk_app_homepage(app_name);
     } catch (error) {
-        console.log('Error:', error);
-        alert('Error:' + error);
+        console.log('Error: ', error);
+        alert('Error: ' + error);
     }
 }

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "bitwarden_event_logs"
-version = "1.2.0"
+version = "1.2.1"
 description = "A Splunk app for reporting Bitwarden event logs."
 authors = [
     "Bitwarden <[email protected]>"

src/config.py

@@ -8,7 +8,7 @@
     BitwardenEventsRequest
 )
 from splunk_api import SplunkApi
-from utils import get_logger, set_logging_level, obj_to_json, app_name
+from utils import get_logger, set_logging_level, obj_to_json, app_name, secure_url
 
 
 class Config:
@@ -87,8 +87,8 @@ def __parse_settings_config(cls, settings: Optional[Dict[str, Dict[str, Any]]])
 
         start_date = datetime_from_str(settings_config.get('startDate', None))
 
-        return SettingsConfig(api_url=api_url,
-                              identity_url=identity_url,
+        return SettingsConfig(api_url=secure_url(api_url),
+                              identity_url=secure_url(identity_url),
                               start_date=start_date,
                               logging_level=settings_config.get('loggingLevel', None))
 

src/utils.py

@@ -9,8 +9,11 @@
 
 from mappers import datetime_to_str
 
+from urllib.parse import urlparse
+
 app_name = "bitwarden_event_logs_beta"
 
+
 def read_session_token() -> str:
     session_token = sys.stdin.readline(5000).strip()
     if session_token is None or session_token == '':
@@ -54,3 +57,11 @@ def json_serial(obj2):
     return json.dumps(obj_dict,
                       default=json_serial,
                       separators=(",", ":"))
+
+
+def secure_url(url: str):
+    result = urlparse(url, scheme='https')
+    if result.scheme == 'http':
+        raise Exception("URLs starting with 'http://' is considered insecure and not allowed in Splunk. "
+                        "Please use 'https://' instead.")
+    return result.geturl()