Release 59cee6ee206ff97a58b0102195c0b0a81e6bf67d (#22)

Author: Hinton

Package.swift

@@ -27,8 +27,8 @@ let package = Package(
             swiftSettings: [.unsafeFlags(["-suppress-warnings"])]),
         .binaryTarget(
             name: "BitwardenFFI",
-            url: "https://bwlivefronttest.blob.core.windows.net/sdk/de3b6e2-BitwardenFFI.xcframework.zip",
-            checksum: "37e884d820907af85e788b5e0ab483bfc5aa0299e5d6b39865ad70659322a202"),
+            url: "https://bwlivefronttest.blob.core.windows.net/sdk/59cee6e-BitwardenFFI.xcframework.zip",
+            checksum: "6539debb4d746c5fda9cd4ff36828d6ff65d84ca15dcb71746ef6420ce3775a2"),
         .testTarget(
             name: "BitwardenSdkTests",
             dependencies: ["BitwardenSdk"])

Sources/BitwardenSdk/BitwardenCore.swift

@@ -50,9 +50,11 @@ fileprivate extension ForeignBytes {
 
 fileprivate extension Data {
     init(rustBuffer: RustBuffer) {
-        // TODO: This copies the buffer. Can we read directly from a
-        // Rust buffer?
-        self.init(bytes: rustBuffer.data!, count: Int(rustBuffer.len))
+        self.init(
+            bytesNoCopy: rustBuffer.data!,
+            count: Int(rustBuffer.len),
+            deallocator: .none
+        )
     }
 }
 

Sources/BitwardenSdk/BitwardenCrypto.swift

@@ -50,9 +50,11 @@ fileprivate extension ForeignBytes {
 
 fileprivate extension Data {
     init(rustBuffer: RustBuffer) {
-        // TODO: This copies the buffer. Can we read directly from a
-        // Rust buffer?
-        self.init(bytes: rustBuffer.data!, count: Int(rustBuffer.len))
+        self.init(
+            bytesNoCopy: rustBuffer.data!,
+            count: Int(rustBuffer.len),
+            deallocator: .none
+        )
     }
 }
 

Sources/BitwardenSdk/BitwardenExporters.swift

@@ -50,9 +50,11 @@ fileprivate extension ForeignBytes {
 
 fileprivate extension Data {
     init(rustBuffer: RustBuffer) {
-        // TODO: This copies the buffer. Can we read directly from a
-        // Rust buffer?
-        self.init(bytes: rustBuffer.data!, count: Int(rustBuffer.len))
+        self.init(
+            bytesNoCopy: rustBuffer.data!,
+            count: Int(rustBuffer.len),
+            deallocator: .none
+        )
     }
 }
 

Sources/BitwardenSdk/BitwardenFido.swift

@@ -50,9 +50,11 @@ fileprivate extension ForeignBytes {
 
 fileprivate extension Data {
     init(rustBuffer: RustBuffer) {
-        // TODO: This copies the buffer. Can we read directly from a
-        // Rust buffer?
-        self.init(bytes: rustBuffer.data!, count: Int(rustBuffer.len))
+        self.init(
+            bytesNoCopy: rustBuffer.data!,
+            count: Int(rustBuffer.len),
+            deallocator: .none
+        )
     }
 }
 

Sources/BitwardenSdk/BitwardenGenerators.swift

@@ -50,9 +50,11 @@ fileprivate extension ForeignBytes {
 
 fileprivate extension Data {
     init(rustBuffer: RustBuffer) {
-        // TODO: This copies the buffer. Can we read directly from a
-        // Rust buffer?
-        self.init(bytes: rustBuffer.data!, count: Int(rustBuffer.len))
+        self.init(
+            bytesNoCopy: rustBuffer.data!,
+            count: Int(rustBuffer.len),
+            deallocator: .none
+        )
     }
 }
 
@@ -591,22 +593,22 @@ public struct PasswordGeneratorRequest {
     public let avoidAmbiguous: Bool
     /**
      * The minimum number of lowercase characters in the generated password.
-     * When set, the value must be between 1 and 9. This value is ignored is lowercase is false
+     * When set, the value must be between 1 and 9. This value is ignored if lowercase is false.
      */
     public let minLowercase: UInt8?
     /**
      * The minimum number of uppercase characters in the generated password.
-     * When set, the value must be between 1 and 9. This value is ignored is uppercase is false
+     * When set, the value must be between 1 and 9. This value is ignored if uppercase is false.
      */
     public let minUppercase: UInt8?
     /**
      * The minimum number of numbers in the generated password.
-     * When set, the value must be between 1 and 9. This value is ignored is numbers is false
+     * When set, the value must be between 1 and 9. This value is ignored if numbers is false.
      */
     public let minNumber: UInt8?
     /**
      * The minimum number of special characters in the generated password.
-     * When set, the value must be between 1 and 9. This value is ignored is special is false
+     * When set, the value must be between 1 and 9. This value is ignored if special is false.
      */
     public let minSpecial: UInt8?
 
@@ -635,19 +637,19 @@ public struct PasswordGeneratorRequest {
          */avoidAmbiguous: Bool, 
         /**
          * The minimum number of lowercase characters in the generated password.
-         * When set, the value must be between 1 and 9. This value is ignored is lowercase is false
+         * When set, the value must be between 1 and 9. This value is ignored if lowercase is false.
          */minLowercase: UInt8?, 
         /**
          * The minimum number of uppercase characters in the generated password.
-         * When set, the value must be between 1 and 9. This value is ignored is uppercase is false
+         * When set, the value must be between 1 and 9. This value is ignored if uppercase is false.
          */minUppercase: UInt8?, 
         /**
          * The minimum number of numbers in the generated password.
-         * When set, the value must be between 1 and 9. This value is ignored is numbers is false
+         * When set, the value must be between 1 and 9. This value is ignored if numbers is false.
          */minNumber: UInt8?, 
         /**
          * The minimum number of special characters in the generated password.
-         * When set, the value must be between 1 and 9. This value is ignored is special is false
+         * When set, the value must be between 1 and 9. This value is ignored if special is false.
          */minSpecial: UInt8?) {
         self.lowercase = lowercase
         self.uppercase = uppercase

Sources/BitwardenSdk/BitwardenSDK.swift

@@ -50,9 +50,11 @@ fileprivate extension ForeignBytes {
 
 fileprivate extension Data {
     init(rustBuffer: RustBuffer) {
-        // TODO: This copies the buffer. Can we read directly from a
-        // Rust buffer?
-        self.init(bytes: rustBuffer.data!, count: Int(rustBuffer.len))
+        self.init(
+            bytesNoCopy: rustBuffer.data!,
+            count: Int(rustBuffer.len),
+            deallocator: .none
+        )
     }
 }
 

Sources/BitwardenSdk/BitwardenSend.swift

@@ -50,9 +50,11 @@ fileprivate extension ForeignBytes {
 
 fileprivate extension Data {
     init(rustBuffer: RustBuffer) {
-        // TODO: This copies the buffer. Can we read directly from a
-        // Rust buffer?
-        self.init(bytes: rustBuffer.data!, count: Int(rustBuffer.len))
+        self.init(
+            bytesNoCopy: rustBuffer.data!,
+            count: Int(rustBuffer.len),
+            deallocator: .none
+        )
     }
 }
 

Sources/BitwardenSdk/BitwardenVault.swift

@@ -50,9 +50,11 @@ fileprivate extension ForeignBytes {
 
 fileprivate extension Data {
     init(rustBuffer: RustBuffer) {
-        // TODO: This copies the buffer. Can we read directly from a
-        // Rust buffer?
-        self.init(bytes: rustBuffer.data!, count: Int(rustBuffer.len))
+        self.init(
+            bytesNoCopy: rustBuffer.data!,
+            count: Int(rustBuffer.len),
+            deallocator: .none
+        )
     }
 }