[SM-1561] fix: cross-compiled bin not working without emulation on host #1176
Conversation
tangowithfoxtrot
changed the title
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
=====================================
Coverage 7.32% 7.32%
=====================================
Files 20 20
Lines 1378 1378
=====================================
Hits 101 101
Misses 1277 1277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
@tangowithfoxtrot looking to clean up old PRs for Platform. Do you think that this should be reassigned to SM for review, since it's the |
trmartin4
changed the title
crates/bws/Dockerfile
Outdated
| WORKDIR /source/crates/bws | ||
| RUN <<EOF | ||
| # Building for $TARGETPLATFORM | ||
| # Add Rust toolchains based on $TARGETPLATFORM |
There was a problem hiding this comment.
Building based on $TARGETPLATFORM means we will be using emulation via the container runtime, which significantly increases build times for the image; the last build took a little over an hour :/
However, I haven't had success cross-compiling in such a way that it doesn't result in the errors described in #872.
There was a problem hiding this comment.
I limited the linux/arm builds to only merges to main in this commit: 6084731.
There was a problem hiding this comment.
Actually, since QA will need the linux/arm64 artifacts produced by this change in order to test it, I reverted this change in 7d5f38e.
tangowithfoxtrot
force-pushed
the
fix-cross-compiled-bws-in-docker
branch
from
952f335 to
6084731
Compare
tangowithfoxtrot
force-pushed
the
fix-cross-compiled-bws-in-docker
branch
from
7bdb46a to
02de00e
Compare
…d times on PRs" This reverts commit 6084731. QA will need linux/arm64 artifacts to test this change. We can consider skipping ARM builds in a follow-up to this if the build times are a problem
|
Tracking
https://bitwarden.atlassian.net/browse/SM-1561
📔 Objective
Fix #872. Also statically link libc so that we don't have to copy dynamic dependencies anymore.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes