[PM-14807] Rename sub_title to subtitle (#28)

Subtitle seems more accurate than sub title. `CipherListView` is
currently unused.

Author: Hinton

crates/bitwarden-vault/src/cipher/cipher.rs

@@ -156,7 +156,7 @@ pub struct CipherListView {
     pub key: Option<EncString>,
 
     pub name: String,
-    pub sub_title: String,
+    pub subtitle: String,
 
     pub r#type: CipherListViewType,
 
@@ -353,18 +353,18 @@ impl Cipher {
 /// Builds the subtitle for a card cipher
 fn build_subtitle_card(brand: Option<String>, number: Option<String>) -> String {
     // Attempt to pre-allocate the string with the expected max-size
-    let mut sub_title =
+    let mut subtitle =
         String::with_capacity(brand.as_ref().map(|b| b.len()).unwrap_or_default() + 8);
 
     if let Some(brand) = brand {
-        sub_title.push_str(&brand);
+        subtitle.push_str(&brand);
     }
 
     if let Some(number) = number {
         let number_len = number.len();
         if number_len > 4 {
-            if !sub_title.is_empty() {
-                sub_title.push_str(", ");
+            if !subtitle.is_empty() {
+                subtitle.push_str(", ");
             }
 
             // On AMEX cards we show 5 digits instead of 4
@@ -373,12 +373,12 @@ fn build_subtitle_card(brand: Option<String>, number: Option<String>) -> String
                 _ => 4,
             };
 
-            sub_title.push('*');
-            sub_title.push_str(&number[(number_len - digit_count)..]);
+            subtitle.push('*');
+            subtitle.push_str(&number[(number_len - digit_count)..]);
         }
     }
 
-    sub_title
+    subtitle
 }
 
 /// Builds the subtitle for a card cipher
@@ -390,20 +390,20 @@ fn build_subtitle_identity(first_name: Option<String>, last_name: Option<String>
         (None, None) => 0,
     };
 
-    let mut sub_title = String::with_capacity(len);
+    let mut subtitle = String::with_capacity(len);
 
     if let Some(first_name) = &first_name {
-        sub_title.push_str(first_name);
+        subtitle.push_str(first_name);
     }
 
     if let Some(last_name) = &last_name {
-        if !sub_title.is_empty() {
-            sub_title.push(' ');
+        if !subtitle.is_empty() {
+            subtitle.push(' ');
         }
-        sub_title.push_str(last_name);
+        subtitle.push_str(last_name);
     }
 
-    sub_title
+    subtitle
 }
 
 impl CipherView {
@@ -555,7 +555,7 @@ impl KeyDecryptable<SymmetricCryptoKey, CipherListView> for Cipher {
             collection_ids: self.collection_ids.clone(),
             key: self.key.clone(),
             name: self.name.decrypt_with_key(key).ok().unwrap_or_default(),
-            sub_title: self.get_decrypted_subtitle(key).ok().unwrap_or_default(),
+            subtitle: self.get_decrypted_subtitle(key).ok().unwrap_or_default(),
             r#type: match self.r#type {
                 CipherType::Login => {
                     let login = self
@@ -802,7 +802,7 @@ mod tests {
                 collection_ids: cipher.collection_ids,
                 key: cipher.key,
                 name: "My test login".to_string(),
-                sub_title: "test_username".to_string(),
+                subtitle: "test_username".to_string(),
                 r#type: CipherListViewType::Login {
                     has_fido2: true,
                     totp: cipher.login.as_ref().unwrap().totp.clone()

crates/bitwarden-vault/src/totp.rs

@@ -376,7 +376,7 @@ mod tests {
             collection_ids: vec![],
             key: None,
             name: "My test login".to_string(),
-            sub_title: "test_username".to_string(),
+            subtitle: "test_username".to_string(),
             r#type: CipherListViewType::Login {
                 has_fido2: true,
                 totp: Some("2.hqdioUAc81FsKQmO1XuLQg==|oDRdsJrQjoFu9NrFVy8tcJBAFKBx95gHaXZnWdXbKpsxWnOr2sKipIG43pKKUFuq|3gKZMiboceIB5SLVOULKg2iuyu6xzos22dfJbvx0EHk=".parse().unwrap()),