Bold the Total row label, always render Storage cost, trim DocC

- Splits the billingRow helper so only the label takes a weight
  override (labelWeight, mirroring the repo's
  .styleGuide(.body, weight: .bold) pattern). Using .bodyBold directly
  was ineffective because Text.styleGuide(_:) defaults weight to
  .regular and applies .fontWeight after the font, overriding the bold
  baked into the token.
- Drops the Storage cost row's > 0 zero-suppression so it always
  renders within the billing section ($0.00 when zero), matching web's
  cart-summary always-render pattern alongside Estimated Tax and Total.
- Strips task-anchored DocC sentences that just restated names or
  referenced callers, matching the repo's lean-comment style.

Author: SaintPatrck

BitwardenShared/UI/Billing/PremiumPlan/PremiumPlanState.swift

@@ -67,8 +67,7 @@ struct PremiumPlanState: Equatable {
         return Localizations.negativeX(formatCurrency(subscription.discount))
     }
 
-    /// The estimated tax label (e.g. "$4.55" or "$0.00"). Always renders when a
-    /// subscription exists, mirroring web's cart-summary always-render behavior.
+    /// The estimated tax label (e.g. "$4.55" or "$0.00").
     var estimatedTax: String {
         guard let subscription else { return "" }
         return formatCurrency(subscription.estimatedTax)
@@ -101,14 +100,9 @@ struct PremiumPlanState: Equatable {
         !discount.isEmpty
     }
 
-    /// Whether the storage cost row should be shown.
-    var showStorageCost: Bool {
-        (subscription?.storageCost ?? 0) > 0
-    }
-
-    /// The storage cost label (e.g. "$4.00").
+    /// The storage cost label (e.g. "$4.00" or "$0.00").
     var storageCostLabel: String {
-        guard let subscription, subscription.storageCost > 0 else { return "" }
+        guard let subscription else { return "" }
         return formatCurrency(subscription.storageCost)
     }
 
@@ -122,8 +116,7 @@ struct PremiumPlanState: Equatable {
         return ""
     }
 
-    /// The total label (e.g. "$25.55 / year"). Mirrors web's cart-summary
-    /// Total line, including the cadence suffix.
+    /// The total label (e.g. "$25.55 / year").
     var totalLabel: String {
         guard let subscription else { return "" }
         return Localizations.xAmountPerCadence(

BitwardenShared/UI/Billing/PremiumPlan/PremiumPlanStateTests.swift

@@ -185,24 +185,6 @@ struct PremiumPlanStateTests {
         #expect(!state.showDiscount)
     }
 
-    // MARK: Tests - showStorageCost
-
-    /// `showStorageCost` is true when storage cost is greater than zero.
-    @Test
-    func showStorageCost_true() {
-        var state = PremiumPlanState()
-        state.subscription = .fixture(storageCost: 4)
-        #expect(state.showStorageCost)
-    }
-
-    /// `showStorageCost` is false when storage cost is zero.
-    @Test
-    func showStorageCost_false() {
-        var state = PremiumPlanState()
-        state.subscription = .fixture(storageCost: 0)
-        #expect(!state.showStorageCost)
-    }
-
     // MARK: Tests - storageCostLabel
 
     /// `storageCostLabel` returns the formatted storage cost.
@@ -213,11 +195,18 @@ struct PremiumPlanStateTests {
         #expect(state.storageCostLabel == "$8.00")
     }
 
-    /// `storageCostLabel` returns empty when storage cost is zero.
+    /// `storageCostLabel` returns the formatted zero amount when storage cost is zero.
     @Test
-    func storageCostLabel_noStorage() {
+    func storageCostLabel_zero() {
         var state = PremiumPlanState()
         state.subscription = .fixture(storageCost: 0)
+        #expect(state.storageCostLabel == "$0.00")
+    }
+
+    /// `storageCostLabel` returns empty when subscription is nil.
+    @Test
+    func storageCostLabel_nil() {
+        let state = PremiumPlanState()
         #expect(state.storageCostLabel.isEmpty)
     }
 

BitwardenShared/UI/Billing/PremiumPlan/PremiumPlanView+ViewInspectorTests.swift

@@ -86,8 +86,7 @@ class PremiumPlanViewTests: BitwardenTestCase {
         XCTAssertNotNil(button)
     }
 
-    /// The estimated tax row renders as $0.00 when tax is zero and the
-    /// plan is active. Matches the canonical web cart-summary behavior.
+    /// The estimated tax row renders as $0.00 when tax is zero and the plan is active.
     @MainActor
     func test_estimatedTax_visible_whenZero() throws {
         processor.state.planStatus = .active
@@ -116,8 +115,7 @@ class PremiumPlanViewTests: BitwardenTestCase {
         XCTAssertEqual(processor.effects.last, .managePlanTapped)
     }
 
-    /// The Total row is hidden when the plan is canceled (whole section
-    /// suppressed by `showBillingDetails`).
+    /// The Total row is hidden when the plan is canceled.
     @MainActor
     func test_totalRow_hidden_whenCanceled() throws {
         processor.state.planStatus = .canceled

BitwardenShared/UI/Billing/PremiumPlan/PremiumPlanView.swift

@@ -41,20 +41,18 @@ struct PremiumPlanView: View {
 
     // MARK: Private Views
 
-    /// The billing details section with rows for billing amount, storage cost, and discount.
+    /// The billing details section with rows for billing amount, storage cost, and discount
     @ViewBuilder private var billingSection: some View {
         billingRow(
             label: Localizations.billingAmount,
             value: store.state.billingAmount,
             valueColor: Color(asset: SharedAsset.Colors.textPrimary),
         )
-        if store.state.showStorageCost {
-            billingRow(
-                label: Localizations.storageCost,
-                value: store.state.storageCostLabel,
-                valueColor: Color(asset: SharedAsset.Colors.textPrimary),
-            )
-        }
+        billingRow(
+            label: Localizations.storageCost,
+            value: store.state.storageCostLabel,
+            valueColor: Color(asset: SharedAsset.Colors.textPrimary),
+        )
         if store.state.showDiscount {
             billingRow(
                 label: Localizations.discount,
@@ -71,7 +69,7 @@ struct PremiumPlanView: View {
             label: Localizations.total,
             value: store.state.totalLabel,
             valueColor: Color(asset: SharedAsset.Colors.textPrimary),
-            font: .bodyBold,
+            labelWeight: .bold,
         )
     }
 
@@ -157,24 +155,23 @@ struct PremiumPlanView: View {
     ///   - label: The label text displayed on the left.
     ///   - value: The value text displayed on the right.
     ///   - valueColor: The color to use for the value text.
-    ///   - font: The style guide font applied to both the label and the value. Defaults to `.body`;
-    ///     the Total row passes `.bodyBold` to match the design's emphasized total typography.
+    ///   - labelWeight: The font weight applied to the label.
     ///
     private func billingRow(
         label: String,
         value: String,
         valueColor: Color,
-        font: StyleGuideFont = .body,
+        labelWeight: SwiftUI.Font.Weight = .regular,
     ) -> some View {
         HStack {
             Text(label)
-                .styleGuide(font)
+                .styleGuide(.body, weight: labelWeight)
                 .foregroundColor(Color(asset: SharedAsset.Colors.textSecondary))
 
             Spacer()
 
             Text(value)
-                .styleGuide(font)
+                .styleGuide(.body)
                 .foregroundColor(valueColor)
         }
         .padding(.vertical, 20)