Skip to content

Commit de3759f

Browse files
authored
refactor(sso-config-tweaks): [Auth/PM-933] Tweaks to SSO Config Page (#16374)
Makes some tweaks to the SSO config page: - SSO Identifier: update hint text - Single Sign-On Service URL: make required, remove hint text - Client Secret: make hidden by default (add view/hide toggle)
1 parent 7b94d6a commit de3759f

File tree

3 files changed

+20
-8
lines changed

3 files changed

+20
-8
lines changed

apps/web/src/locales/en/messages.json

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5219,9 +5219,13 @@
52195219
"ssoIdentifier": {
52205220
"message": "SSO identifier"
52215221
},
5222-
"ssoIdentifierHintPartOne": {
5223-
"message": "Provide this ID to your members to login with SSO. To bypass this step, set up ",
5224-
"description": "This will be used as part of a larger sentence, broken up to include links. The full sentence will read 'Provide this ID to your members to login with SSO. To bypass this step, set up Domain verification'"
5222+
"ssoIdentifierHint": {
5223+
"message": "Provide this ID to your members to login with SSO. Members can skip entering this identifier during SSO if a claimed domain is set up. ",
5224+
"description": "This will be used as part of a larger sentence, broken up to include a link. The full sentence will read 'Provide this ID to your members to login with SSO. Members can skip entering this identifier during SSO if a claimed domain is set up. Learn more'"
5225+
},
5226+
"claimedDomainsLearnMore": {
5227+
"message": "Learn more",
5228+
"description": "This will be used as part of a larger sentence, broken up to include a link. The full sentence will read 'Provide this ID to your members to login with SSO. Members can skip entering this identifier during SSO if a claimed domain is set up. Learn more'"
52255229
},
52265230
"unlinkSso": {
52275231
"message": "Unlink SSO"

bitwarden_license/bit-web/src/app/auth/sso/sso.component.html

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
<bit-label>{{ "ssoIdentifier" | i18n }}</bit-label>
3131
<input bitInput type="text" formControlName="ssoIdentifier" />
3232
<bit-hint>
33-
{{ "ssoIdentifierHintPartOne" | i18n }}
34-
<a bitLink routerLink="../domain-verification">{{ "claimedDomains" | i18n }}</a>
33+
{{ "ssoIdentifierHint" | i18n }}
34+
<a bitLink routerLink="../domain-verification">{{ "claimedDomainsLearnMore" | i18n }}</a>
3535
</bit-hint>
3636
</bit-form-field>
3737

@@ -209,7 +209,14 @@ <h2 bitTypography="h2">
209209

210210
<bit-form-field>
211211
<bit-label>{{ "clientSecret" | i18n }}</bit-label>
212-
<input bitInput type="text" formControlName="clientSecret" appInputStripSpaces />
212+
<input bitInput type="password" formControlName="clientSecret" appInputStripSpaces />
213+
<button
214+
type="button"
215+
bitIconButton
216+
bitSuffix
217+
bitPasswordInputToggle
218+
[(toggled)]="showClientSecret"
219+
></button>
213220
</bit-form-field>
214221

215222
<bit-form-field>
@@ -488,7 +495,6 @@ <h2 bitTypography="h2">
488495
formControlName="idpSingleSignOnServiceUrl"
489496
appInputStripSpaces
490497
/>
491-
<bit-hint>{{ "idpSingleSignOnServiceUrlRequired" | i18n }}</bit-hint>
492498
</bit-form-field>
493499

494500
<bit-form-field>

bitwarden_license/bit-web/src/app/auth/sso/sso.component.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ export class SsoComponent implements OnInit, OnDestroy {
121121
spMetadataUrl: string;
122122
spAcsUrl: string;
123123

124+
showClientSecret = false;
125+
124126
protected openIdForm = this.formBuilder.group<ControlsOf<SsoConfigView["openId"]>>(
125127
{
126128
authority: new FormControl("", Validators.required),
@@ -156,7 +158,7 @@ export class SsoComponent implements OnInit, OnDestroy {
156158

157159
idpEntityId: new FormControl("", Validators.required),
158160
idpBindingType: new FormControl(Saml2BindingType.HttpRedirect),
159-
idpSingleSignOnServiceUrl: new FormControl(),
161+
idpSingleSignOnServiceUrl: new FormControl("", Validators.required),
160162
idpSingleLogoutServiceUrl: new FormControl(),
161163
idpX509PublicCert: new FormControl("", Validators.required),
162164
idpOutboundSigningAlgorithm: new FormControl(defaultSigningAlgorithm),

0 commit comments

Comments
 (0)