update variable naming for premium filters

Author: nick-livefront

apps/web/src/app/vault/individual-vault/vault-filter/components/vault-filter.component.ts

@@ -453,7 +453,7 @@ export class VaultFilterComponent implements OnInit, OnDestroy {
       },
       action: this.applyTypeFilter as (filterNode: TreeNode<VaultFilterType>) => Promise<void>,
       premiumOptions: {
-        showPremiumBadge: true,
+        showBadgeForNonPremium: true,
         blockFilterAction: promptForPremiumOnFilter
           ? async () => await this.premiumUpgradePromptService.promptForPremium()
           : undefined,

apps/web/src/app/vault/individual-vault/vault-filter/shared/components/vault-filter-section.component.ts

@@ -123,7 +123,7 @@ export class VaultFilterSectionComponent implements OnInit, OnDestroy {
   }
 
   get premiumFeature() {
-    return this.section?.premiumOptions?.showPremiumBadge;
+    return this.section?.premiumOptions?.showBadgeForNonPremium;
   }
 
   get divider() {

apps/web/src/app/vault/individual-vault/vault-filter/shared/models/vault-filter-section.type.ts

@@ -49,8 +49,12 @@ export type VaultFilterSection = {
   divider?: boolean;
   premiumOptions?: {
     /**  When true, the premium badge will show on the filter for non-premium users. */
-    showPremiumBadge?: true;
-    /** Action to be called instead of applying the filter. */
+    showBadgeForNonPremium?: true;
+    /**
+     * Action to be called instead of applying the filter.
+     * Useful when the user does not have access to a filter (e.g., premium feature)
+     * and custom behavior is needed when invoking the filter.
+     */
     blockFilterAction?: () => Promise<void>;
   };
 };