[PM-21405] Delete account error message (#5237)

Author: andrebispo5

app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt

@@ -794,6 +794,37 @@ class AuthRepositoryTest {
         }
     }
 
+    @Test
+    fun `delete account fails if deleteAccount fails with message`() = runTest {
+        val masterPassword = "hello world"
+        val hashedMasterPassword = "dlrow olleh"
+        fakeAuthDiskSource.userState = SINGLE_USER_STATE_1
+        val kdf = SINGLE_USER_STATE_1.activeAccount.profile.toSdkParams()
+        coEvery {
+            authSdkSource.hashPassword(EMAIL, masterPassword, kdf, HashPurpose.SERVER_AUTHORIZATION)
+        } returns hashedMasterPassword.asSuccess()
+        coEvery {
+            accountsService.deleteAccount(
+                masterPasswordHash = hashedMasterPassword,
+                oneTimePassword = null,
+            )
+        } returns DeleteAccountResponseJson.Invalid(
+            errorMessage = "Fail",
+            validationErrors = null,
+        ).asSuccess()
+
+        val result = repository.deleteAccountWithMasterPassword(masterPassword = masterPassword)
+
+        assertEquals(DeleteAccountResult.Error(message = "Fail", error = null), result)
+        coVerify {
+            authSdkSource.hashPassword(EMAIL, masterPassword, kdf, HashPurpose.SERVER_AUTHORIZATION)
+            accountsService.deleteAccount(
+                masterPasswordHash = hashedMasterPassword,
+                oneTimePassword = null,
+            )
+        }
+    }
+
     @Test
     fun `deleteAccountWithMasterPassword succeeds`() = runTest {
         val masterPassword = "hello world"

network/src/main/kotlin/com/bitwarden/network/model/DeleteAccountResponseJson.kt

@@ -16,12 +16,16 @@ sealed class DeleteAccountResponseJson {
     /**
      * Models the json body of a deletion error.
      *
+     * @param errorMessage a human readable error message.
      * @param validationErrors a map where each value is a list of error messages for each key.
      * The values in the array should be used for display to the user, since the keys tend to come
      * back as nonsense. (eg: empty string key)
      */
     @Serializable
     data class Invalid(
+        @SerialName("message")
+        private val errorMessage: String?,
+
         @SerialName("validationErrors")
         private val validationErrors: Map<String, List<String?>>?,
     ) : DeleteAccountResponseJson() {
@@ -33,5 +37,6 @@ sealed class DeleteAccountResponseJson {
                 ?.values
                 ?.firstOrNull()
                 ?.firstOrNull()
+                ?: errorMessage
     }
 }