Add eclair support #2 #724

macgyver13 · 2025-06-19T01:59:18Z

This PR adds eclair support to warnet and sim-ln

Notes:

upgrade sim-ln plugin to 0.2.4 for eclair support
pin eclair docker image to 0.11.0 version - address persistent crash with 0.12.0+ (secp256k1_der_parse_integer+0x166)
eclair 0.11.0 requires bitcoin core 27.2+ (tested with 28.1 and 29.0)
enable txindex on bitcoin core
support switching zmqblock format on bitcoin core node - eclair and lnd require different format
now LNNode instances can be used in test with common syntax between ln nodes
- newaddress
- nodeid
- uri
- walletbalance
- channelbalance
- connect
- channel
- createinvoice
- payinvoice
- graph

Breaking change (bitcoincore chart dependencies):

previous

ln:
  lnd: true
lnd:
  channels:

proposed

lnd:
  enabled: true
  channels:

override network graph check for eclair nodes pin eclair docker image to 0.11.0 version enable keysend feature for eclair handle new enabled scheme for ln nodes conditional enable wallets for eclair nodes update documentation to use new ln node enable scheme

pinheadmz · 2025-06-26T15:22:56Z

eclair_multi.zip

can you add eclair to one of our existing tests? or add a new 3-implementation interop test?

pinheadmz · 2025-07-02T18:18:00Z

I cherry-picked the lint fix to main, if you wanna rebase to run ci

* main: Fix Python 3.9 compatibility: replace match statement with if/elif admin scenarios access logs

fix proc exception, add --debug command support

add new ln_mixed_test add support for switching zmqblock format on bitcoin core node

macgyver13 · 2025-07-09T02:46:59Z

eclair_multi.zip

can you add eclair to one of our existing tests? or add a new 3-implementation interop test?

added ln_mixed_test

pinheadmz · 2025-07-09T18:10:09Z

I got a bunch of errors running ln_mixed_test locally: https://gist.github.com/pinheadmz/2525b9672944516857811b97d6ae7072

Looks mostly like the rune wasn't in place at the right time?

macgyver13 · 2025-07-09T23:57:32Z

I got a bunch of errors running ln_mixed_test locally: https://gist.github.com/pinheadmz/2525b9672944516857811b97d6ae7072

Looks mostly like the rune wasn't in place at the right time?

Commit fdbaf71 adds CLN startup probe. Let me know if you have better results

pinheadmz · 2025-07-10T11:05:55Z

Awesome work ok so CLN seems definitely more reliable, but theres an issue with eclair where i think it restarts after making peer connections, and then those peer connections don't come back:

warnet test log:

tank-0001-ln - ERROR: Error ECLAIR POST, Abort: [Errno 111] Connection refused
    (...)
tank-0001-ln - WARNING: unable to open channel: {"error":"peer 02dd93febc114e42f26567ee80b343fe0cea699f514adf6e205fc831c591f19fdf not found"}, wait and retry...
tank-0001-ln - WARNING: unable to open channel: {"error":"peer 02dd93febc114e42f26567ee80b343fe0cea699f514adf6e205fc831c591f19fdf not found"}, wait and retry...
    (...)
LNInit   - Unexpected channel open response:
  From tank-0001-ln -> tank-0003-ln fee_rate=5001
  None

eclair log, reporting 2 restarts in kubernetes:

2025-07-10 11:02:45,066 ERROR f.a.eclair.Boot - API call failed with cause=peer 02dd93febc114e42f26567ee80b343fe0cea699f514adf6e205fc831c591f19fdf not found

macgyver13 · 2025-07-10T12:46:33Z

tank-0001-ln - ERROR: Error ECLAIR POST, Abort: [Errno 111] Connection refused
(...)
tank-0001-ln - WARNING: unable to open channel: {"error":"peer 02dd93febc114e42f26567ee80b343fe0cea699f514adf6e205fc831c591f19fdf not found"}, wait and retry...
tank-0001-ln - WARNING: unable to open channel: {"error":"peer 02dd93febc114e42f26567ee80b343fe0cea699f514adf6e205fc831c591f19fdf not found"}, wait and retry...
(...)
LNInit - Unexpected channel open response:
From tank-0001-ln -> tank-0003-ln fee_rate=5001
None

commit c99f8fd extends retry delay

update to polarlightning/eclair 0.12.0

pinheadmz · 2025-07-11T10:54:36Z

resources/charts/bitcoincore/values.yaml

@@ -129,6 +129,7 @@ baseConfig: |
  rpcallowip=0.0.0.0/0
  rpcbind=0.0.0.0
  rest=1
+  dnsseed=0 # needed for eclair stability


lets take this out, it may have a broader impact on bitcoin p2p in warnet and i just don't see how it could possibly affect eclair

want to conditionally add dnsseed property for bitcoincore nodes attached to eclair or just remove all together?

remove altogether - I can't see how eclair needs this

pinheadmz · 2025-07-11T11:03:27Z

This is something else we need to fix -- all of these "wait for gossip" loops in ln_init must never time out and continue with incomplete gossip. We just have to wait forever

Sorry I shouldve called this out in the CLN pull request, but those nodes worked better so I didn't notice.

warnet/resources/scenarios/ln_init.py

Lines 286 to 294 in 4d12d87

    
               if attempts > 10: 
        
                   break 
        
               attempts += 1 
        
               sleep(5) 
        
           if actual == expected: 
        
               self.log.info(f"LN {ln.name} has graph with all {expected} channels") 
        
           else: 
        
               self.log.error( 
        
                   f"LN {ln.name} graph is INCOMPLETE - {actual} of {expected} channels"

macgyver13 added 3 commits June 18, 2025 20:36

fix format

06e4366

fix fee rate calculation assumptions for eclair channels

3238e64

This comment was marked as outdated.

Sign in to view

macgyver13 added 6 commits July 2, 2025 14:30

Merge branch 'main' into add-eclair

d56b880

* main: Fix Python 3.9 compatibility: replace match statement with if/elif admin scenarios access logs

correct lnd node syntax graph::import-network

efb2deb

remove fixme

d509de0

fix logging test - enable lnd to satisfy metric

4aadc52

fix proc exception, add --debug command support

reverse capture_output change

8291e7e

add support for testing LNNode through rpc

4a109cf

add new ln_mixed_test add support for switching zmqblock format on bitcoin core node

macgyver13 marked this pull request as ready for review July 9, 2025 02:49

fix eclair channelbalance calculation issue

f232768

make cln rune creation more robust with startupProbe

fdbaf71

increase delay on eclair channel open retries

c99f8fd

address eclair stability with dnsseed bitcoin core config

4d12d87

update to polarlightning/eclair 0.12.0

pinheadmz reviewed Jul 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add eclair support #2 #724

Add eclair support #2 #724

Uh oh!

macgyver13 commented Jun 19, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

pinheadmz commented Jun 26, 2025

Uh oh!

pinheadmz commented Jul 2, 2025

Uh oh!

macgyver13 commented Jul 9, 2025

Uh oh!

pinheadmz commented Jul 9, 2025

Uh oh!

macgyver13 commented Jul 9, 2025

Uh oh!

pinheadmz commented Jul 10, 2025

Uh oh!

macgyver13 commented Jul 10, 2025

Uh oh!

pinheadmz Jul 11, 2025

Uh oh!

macgyver13 Jul 11, 2025

Uh oh!

pinheadmz Jul 11, 2025

Uh oh!

pinheadmz commented Jul 11, 2025

Uh oh!

Uh oh!

Add eclair support #2 #724

Are you sure you want to change the base?

Add eclair support #2 #724

Uh oh!

Conversation

macgyver13 commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking change (bitcoincore chart dependencies):

Uh oh!

This comment was marked as outdated.

pinheadmz commented Jun 26, 2025

Uh oh!

pinheadmz commented Jul 2, 2025

Uh oh!

macgyver13 commented Jul 9, 2025

Uh oh!

pinheadmz commented Jul 9, 2025

Uh oh!

macgyver13 commented Jul 9, 2025

Uh oh!

pinheadmz commented Jul 10, 2025

Uh oh!

macgyver13 commented Jul 10, 2025

Uh oh!

pinheadmz Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

macgyver13 Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

pinheadmz Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

pinheadmz commented Jul 11, 2025

Uh oh!

Uh oh!

macgyver13 commented Jun 19, 2025 •

edited

Loading