suspect Ping() does not "establishing a connection if necessary"

[mangup]

"Ping verifies a connection to the database is still alive, establishing a connection if necessary."
But I've got an error message from it - "write tcp 172.22.0.2:38686->10.2.44.115:21050: write: broken pipe"

Does Ping() works wrong or its description is incorrect?

[murfffi]

I improved on this behavior in https://github.com/sclgo/impala-go - the actively supported fork of this driver.

Note that Ping is allowed to return errors - based on https://pkg.go.dev/database/sql/driver#Pinger and the code of https://pkg.go.dev/database/sql#DB.PingContext . I think that "establishing a connection if necessary", means that a connection will be established if we haven't connected already.

In case the connection is broken, the driver.Ping method must return an error with ErrBadConn in the chain so the database/sql removes that connection from the pool. The next call to db.Ping or db.PingContext will establish a new connection and will succeed (if the server itself is working).
This driver does return ErrBadConn in some cases but missed a couple of important ones. sclgo#28 resolved that.