Skip to content

Commit 8f1cfa3

Browse files
committed
Remove Obsolete PID parameters
1 parent 9ce045c commit 8f1cfa3

File tree

3 files changed

+3
-22
lines changed

3 files changed

+3
-22
lines changed

index.html

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -608,16 +608,6 @@ <h5 class="modal-title-craft"></h5>
608608
</tr>
609609
</thead>
610610
<tbody>
611-
<tr>
612-
<th colspan="2">Tolerance</th>
613-
<th colspan="2"></th>
614-
</tr>
615-
<tr>
616-
<td name="toleranceBand"><label>Band</label><input type="number" step="1" min="0" max="999" /></td>
617-
<td name="toleranceBandReduction"><label>Reduction</label><input type="number" step="1" min="0" max="999" /></td>
618-
<td name="zeroCrossAllowanceCount" class="bf-only"><label>Zero Cross Count</label><input type="number" step="1" min="0" max="999" /></td>
619-
<td name="itermThrottleGain" class="bf-only"><label>I-Term Throttle Gain</label><input type="number" step="0.01" min="0" max="999" /></td>
620-
</tr>
621611
<tr>
622612
<th colspan="2">Setpoint Weight</th>
623613
<th colspan="2">Acceleration Limit</th>
@@ -628,6 +618,9 @@ <h5 class="modal-title-craft"></h5>
628618
<td name="rateAccelLimit" class="bf-only"><label>Roll/Pitch Rate</label><input type="number" step="1" min="0" max="999" /></td>
629619
<td name="yawRateAccelLimit" class="bf-only"><label>Yaw</label><input type="number" step="1" min="0" max="999" /></td>
630620
</tr>
621+
<tr>
622+
<td name="itermThrottleGain" class="bf-only"><label>I-Term Throttle Gain</label><input type="number" step="0.01" min="0" max="999" /></td>
623+
</tr>
631624
</tbody>
632625
</table>
633626
</div>

js/flightlog_parser.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -247,9 +247,6 @@ var FlightLogParser = function(logData) {
247247
rc_interpolation_interval:null, // RC Control Interpolation Interval
248248
dterm_filter_type:null, // D term filtering type (PT1, BIQUAD)
249249
pidAtMinThrottle:null, // Stabilisation at zero throttle
250-
toleranceBand:null, // Betaflight PID
251-
toleranceBandReduction:null, // Betaflight PID
252-
zeroCrossAllowanceCount:null, // Betaflight PID
253250
itermThrottleGain:null, // Betaflight PID
254251
ptermSetpointWeight:null, // Betaflight PID
255252
dtermSetpointWeight:null, // Betaflight PID
@@ -464,9 +461,6 @@ var FlightLogParser = function(logData) {
464461
case "acc_1G":
465462
case "dterm_filter_type":
466463
case "pidAtMinThrottle":
467-
case "toleranceBand":
468-
case "toleranceBandReduction":
469-
case "zeroCrossAllowanceCount":
470464
case "itermThrottleGain":
471465
case "ptermSetpointWeight":
472466
case "dtermSetpointWeight":

js/header_dialog.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@ function HeaderDialog(dialog, onSave) {
4242
{name:'serialrx_provider' , type:FIRMWARE_TYPE_BETAFLIGHT, min:3.0, max:999.9},
4343
{name:'dterm_filter_type' , type:FIRMWARE_TYPE_BETAFLIGHT, min:3.0, max:999.9},
4444
{name:'pidAtMinThrottle' , type:FIRMWARE_TYPE_BETAFLIGHT, min:3.0, max:999.9},
45-
{name:'toleranceBand' , type:FIRMWARE_TYPE_BETAFLIGHT, min:3.0, max:999.9},
46-
{name:'toleranceBandReduction' , type:FIRMWARE_TYPE_BETAFLIGHT, min:3.0, max:999.9},
47-
{name:'zeroCrossAllowanceCount' , type:FIRMWARE_TYPE_BETAFLIGHT, min:3.0, max:999.9},
4845
{name:'itermThrottleGain' , type:FIRMWARE_TYPE_BETAFLIGHT, min:3.0, max:999.9},
4946
{name:'ptermSetpointWeight' , type:FIRMWARE_TYPE_BETAFLIGHT, min:3.0, max:999.9},
5047
{name:'dtermSetpointWeight' , type:FIRMWARE_TYPE_BETAFLIGHT, min:3.0, max:999.9},
@@ -442,9 +439,6 @@ function HeaderDialog(dialog, onSave) {
442439
renderSelect('fast_pwm_protocol' ,sysConfig.fast_pwm_protocol, FAST_PROTOCOL);
443440
setParameter('motor_pwm_rate' ,sysConfig.motor_pwm_rate,0);
444441
renderSelect('dterm_filter_type' ,sysConfig.dterm_filter_type, FILTER_TYPE);
445-
setParameter('toleranceBand' ,sysConfig.toleranceBand,2);
446-
setParameter('toleranceBandReduction' ,sysConfig.toleranceBandReduction,2);
447-
setParameter('zeroCrossAllowanceCount' ,sysConfig.zeroCrossAllowanceCount,0);
448442
setParameter('itermThrottleGain' ,sysConfig.itermThrottleGain,2);
449443
setParameter('ptermSetpointWeight' ,sysConfig.ptermSetpointWeight,2);
450444
setParameter('dtermSetpointWeight' ,sysConfig.dtermSetpointWeight,2);

0 commit comments

Comments
 (0)