Skip to content

Commit f82ccf9

Browse files
authored
Support dynamic reloading (#341)
1 parent 06f163a commit f82ccf9

File tree

8 files changed

+10
-8
lines changed

8 files changed

+10
-8
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44

55
## Unreleased
66

7+
- Fix warnings and deprecations
8+
- Support dynamic reloading
9+
710
## 4.5.0 - 2024-09-02
811

912
- Fix BitBucket cloud URL generation when the remote contains scm (#333)

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
pluginGroup = uk.co.ben_gibson.git.link
55
pluginName = GitLink
66
# SemVer format -> https://semver.org
7-
pluginVersion = 4.5.0
7+
pluginVersion = 4.5.1
88

99
# See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
1010
# for insight into build numbers and IntelliJ Platform versions.

src/main/kotlin/uk/co/ben_gibson/git/link/GitLinkBundle.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,12 @@ import com.intellij.openapi.options.ShowSettingsUtil
88
import com.intellij.openapi.project.Project
99
import org.jetbrains.annotations.NonNls
1010
import org.jetbrains.annotations.PropertyKey
11-
import java.net.URL
1211

1312
@NonNls
1413
private const val BUNDLE = "messages.MyBundle"
1514

1615
object GitLinkBundle : DynamicBundle(BUNDLE) {
17-
val URL_BUG_REPORT = URL("https://github.com/ben-gibson/GitLink/issues")
16+
const val URL_BUG_REPORT = "https://github.com/ben-gibson/GitLink/issues"
1817

1918
@Suppress("SpreadOperator")
2019
@JvmStatic

src/main/kotlin/uk/co/ben_gibson/git/link/settings/ProjectSettings.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package uk.co.ben_gibson.git.link.settings
22

33
import com.intellij.openapi.components.PersistentStateComponent
4+
import com.intellij.openapi.components.Service
45
import com.intellij.openapi.components.State
56
import com.intellij.openapi.components.Storage
67
import com.intellij.util.xmlb.XmlSerializerUtil
@@ -10,6 +11,7 @@ import com.intellij.util.xmlb.XmlSerializerUtil
1011
* The [State] and [Storage] annotations define the name of the data and the file name where
1112
* these persistent application settings are stored.
1213
*/
14+
@Service(Service.Level.PROJECT)
1315
@State(name = "uk.co.ben_gibson.git.link.SettingsState", storages = [Storage("GitLink.xml")])
1416
class ProjectSettings : PersistentStateComponent<ProjectSettings?> {
1517
var host: String? = null

src/main/kotlin/uk/co/ben_gibson/git/link/ui/settings/CustomPlatformSettingsConfigurable.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class CustomPlatformSettingsConfigurable : BoundConfigurable(message("settings.c
4242
.align(Align.FILL)
4343
}
4444
row {
45-
browserLink(message("actions.report-bug.title"), GitLinkBundle.URL_BUG_REPORT.toString())
45+
browserLink(message("actions.report-bug.title"), GitLinkBundle.URL_BUG_REPORT)
4646
}
4747
}
4848

src/main/kotlin/uk/co/ben_gibson/git/link/ui/settings/DomainRegistrySettings.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class DomainRegistrySettings : BoundConfigurable(message("settings.domain-regist
7070
.align(Align.FILL)
7171
}
7272
row {
73-
browserLink(message("actions.report-bug.title"), GitLinkBundle.URL_BUG_REPORT.toString())
73+
browserLink(message("actions.report-bug.title"), GitLinkBundle.URL_BUG_REPORT)
7474
}
7575
}
7676

src/main/kotlin/uk/co/ben_gibson/git/link/ui/settings/ProjectSettingsConfigurable.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class ProjectSettingsConfigurable(project : Project) : BoundConfigurable(message
5353
}
5454
}
5555
row {
56-
browserLink(message("actions.report-bug.title"), GitLinkBundle.URL_BUG_REPORT.toString())
56+
browserLink(message("actions.report-bug.title"), GitLinkBundle.URL_BUG_REPORT)
5757
}
5858
}
5959

src/main/resources/META-INF/plugin.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111
</description>
1212

1313
<extensions defaultExtensionNs="com.intellij">
14-
<projectService serviceImplementation="uk.co.ben_gibson.git.link.settings.ProjectSettings"/>
1514
<applicationService serviceImplementation="uk.co.ben_gibson.git.link.settings.ApplicationSettings"/>
16-
<notification.parentGroup id="git.link.notifications"/>
1715
<notificationGroup id="git.link.notification.general" displayType="BALLOON" key="notification.group.general.name" />
1816
<notificationGroup id="git.link.notification.important" displayType="STICKY_BALLOON" key="notification.group.important.name" />
1917
<postStartupActivity implementation="uk.co.ben_gibson.git.link.listener.ApplicationStartupListener"/>

0 commit comments

Comments
 (0)