Skip to content

[FEAT] Support More Build Targets (Please merge #610) #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uniblab opened this issue May 5, 2025 · 1 comment
Closed

[FEAT] Support More Build Targets (Please merge #610) #616

uniblab opened this issue May 5, 2025 · 1 comment

Comments

@uniblab
Copy link
Contributor

uniblab commented May 5, 2025

Is your feature request related to a problem or specific use case? Please describe.
I am a direct consumer of SSH.NET and therefore a transitive consumer of BouncyCastle.Cryptography. There are improvements I'd like to make to my own programs which require supporting more SSH.NET build targets, which would require supporting more BouncyCastle.Cryptography build targets

Describe the solution you'd like
I have already submitted a Pull Request, #610 , which incorporates the additional build targets. It has passed all the included test cases in all configurations. I want PR #610 merged.

Describe alternatives you've considered
You could copy'n'paste my updates to the csproj files and issue your own PR, but it would be easier to just review and merge my PR.

Product deployment

  • Increment version number to 2.6.0
  • Update Nuget

Additional context
Changes consisted of adding a few more targets to the csproj files and then running the test cases. There are no code changes.

@uniblab uniblab changed the title Support More Build Targets (Please merge #610) [FEAT] Support More Build Targets (Please merge #610) May 5, 2025
@peterdettman
Copy link
Collaborator

Motivation/justification for a PR belongs on the PR itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants