Skip to content

Commit 54293b3

Browse files
linzhpfmeum
andauthored
Fixing default includes of nogo (#4195)
Currently, nogo will only run within rules_go, not the main repo, by default. This PR also remove the setting of `includes` in tests by default to expose issues in the default `includes` of `go_register_nogo` Fixes #4194 --------- Co-authored-by: Fabian Meumertzheim <[email protected]>
1 parent 6e4fdcf commit 54293b3

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

examples/basic-gazelle/.bazelversion

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
7.4.1

go/private/nogo.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# limitations under the License.
1414

1515
DEFAULT_NOGO = "@io_bazel_rules_go//:default_nogo"
16-
NOGO_DEFAULT_INCLUDES = [str(Label("//:__subpackages__"))]
16+
NOGO_DEFAULT_INCLUDES = ["@@//:__subpackages__"]
1717
NOGO_DEFAULT_EXCLUDES = []
1818

1919
# repr(Label(...)) does not emit a canonical label literal.

go/tools/bazel_testing/bazel_testing.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -583,8 +583,6 @@ go_register_nogo(
583583
"{{ . }}",
584584
{{ end }}
585585
],
586-
{{ else }}
587-
includes = ["all"],
588586
{{ end}}
589587
{{ if .NogoExcludes }}
590588
excludes = [

0 commit comments

Comments
 (0)