Update and Add functionalities to the old CLI ver. of Cryptocurrency Converter (Fixed and Refactored.) (HarshCasper#845)

* Update the old CLI ver of crypto_converter.py and fix a few errors.

* Updated the script with suggested refactors and fixes.

* Added an EOF

Author: kshittijagrawal

Python/Cryptocurrency_Converter/crypto_converter.py

@@ -1,110 +1,135 @@
-"""we will be using coinbase API as it is public
-More info below
+"""We will be using coinbase API as it is public.
 https://developers.coinbase.com/api/v2?python#get-exchange-rates"""
 
 import requests
 
+def exchange_rates(exchange_type):
+    """This function gets exhange rates. The coinbase API returns the JSON for an input cryptocurrency 
+    with data or exhangerate of one coin to all known "normal" fiat currencies like BTC(input) to INR, USD etc."""
+    exchange_type = exchange_type.upper()
+    response_obj = requests.get(f"https://api.coinbase.com/v2/exchange-rates?currency={exchange_type}")
 
-def exchange_rates(cryptocurrency):
-    """
-    This function gets exhange rates.
-    The coinbase API returns the JSON for an input cryptocurrency with
-    data or exhangerate of one coin to all known "normal" fiat currencies
-    like BTC(input) to INR,USD,etc.
-    """
-
-    # capitalising the cryptocurrency values as the API accepts and returns
-    cryptocurrency = cryptocurrency.upper()
-
-    # These are the cryptocurrency available currently by the API.
-    # "BTC" is for Bitcoin,"ETH" is for Ethereum and so on
-    available_cryptocurrencies = [
-        'BTC', 'ETH', 'ETC', 'BCH', 'LTC', 'ZEC', 'ZRX']
-
-    if cryptocurrency not in available_cryptocurrencies:
-        return None
-
-    # sending a request to the api and storing the response object in r variable
-    response_obj = requests.get(
-        'https://api.coinbase.com/v2/exchange-rates?currency='+cryptocurrency)
-
-    try:
-        exchange_dict = response_obj.json()["data"]["rates"]
-    except KeyError:
-        return None
+    try: exchange_dict = response_obj.json()["data"]["rates"]
+    except: return None
     return exchange_dict
 
-# This function converts currency amount to cryptocurrency amount
-
 
-def convert_currency_to_crypto(amount, currency, cryptocurrency):
-    """This function converts currency amount to cryptocurrency amount"""
-
-    # checking that the input is correct
-    try:
-        amount = float(amount)
-    except ValueError:
-        return "wrong input!"
+def convert_fiat_to_crypto(fvalue, ftype, ctype):
+    """This function converts Fiat Money to Cryptocurrency amount.
+    Returns 1 if the input is found not valid, converted currency value if the input is found valid, else returns "None".
+    "fvalue" corresponds to Fiat Money value, "ftype" to Fiat Money type and "ctype" to Cryptocurrency type --> all given by the user."""
+    flag, statement = validity_of_currencytype(ctype, ftype)
+    if flag == 1:
+        print(statement)
+        return 1
 
     # get current_price for cryptocurrency using exhange_rates function
-    current_price = exchange_rates(cryptocurrency)[currency]
-
+    try: current_price = exchange_rates(ftype)[ctype]
+    except:
+        print("nNo Information Available. We're Sorry!")
+        return
     if current_price is None:
-        return "No info available"
-
-    return amount/float(current_price)
+        print("\nNo Information Available. We're Sorry!")
+        return
+    return float(current_price)*fvalue
 
 
-def convert_crypto_to_currency(amount, cryptocurrency, currency):
-    """This function converts currency amount to cryptocurrency amount"""
-
-    # Just checking the input
-    try:
-        amount = float(amount)
-    except ValueError:
-        return "wrong input!"
+def convert_crypto_to_fiat(cvalue, ctype, ftype):
+    """This function converts Cryptocurrency amount to Fiat Money.
+    Returns 1 if the input is found not valid, converted currency value if the input is found valid, else returns "None".
+    "cvalue" corresponds to Cryptocurrency value, "ctype" to Cryptocurrency type and "ftype" to Fiat Money type --> all given by the user."""
+    flag, statement = validity_of_currencytype(ctype, ftype)
+    if flag == 1:
+        print(statement)
+        return 1
 
     # get current_price for cryptocurrency using exhange_rates function
-    current_price = exchange_rates(cryptocurrency)[currency]
-
+    try: current_price = exchange_rates(ctype)[ftype]
+    except:
+        print("\nNo Information Available. We're Sorry!")
+        return
     if current_price is None:
-        return "No info available"
+        print("\nNo Information Available. We're Sorry!")
+        return
+    return float(current_price)*cvalue
 
-    return float(current_price)*amount
 
+def validity_of_currencytype(ctype, ftype):
+    """This function checks if the user input of Cryptocurrency type or Fiat Money type are truly the latter.
+    Returns 1 if found an error in the input, else returns 0."""
+    available_cryptocurrencies = ['BTC', 'ETH', 'ETC', 'BCH', 'LTC', 'ZEC', 'ZRX']
+    if ctype not in available_cryptocurrencies:
+        return 1, f"\n{ctype} is not a Cryptocurrency. Try Again!\n"
+    elif ftype in available_cryptocurrencies:
+        return 1, f"\n{ftype} is not a Fiat Money. Try Again!\n"
+    else:
+        return 0, "\nAll Good!"
 
-if __name__ == "__main__":
-    STRING = """
-    ################################################################
-
-    examples of fiat currencies :INR,USD,etc.
-    examples of Cryptocurrencies :BTC,ETH,etc.
-    
-    ################################################################
-
-    Choose one of the below options:
-
-    Convert Cryptocurrency to fiat currency (Enter 1)  
-    Convert fiat currency to Cryptocurrency (Enter 2) 
-    Quit (Enter Q)
-    """
 
+def main():
+    """This function loops through the input given by the user, until given a bad input or "Q/q". """
     while True:
-        print(STRING)
-        user_inp = input()
-        currency = input("Enter fiat currency type:").upper()
-        cryptocurrency = input("Enter Cryptocurrency type:").upper()
-        amount = int(input("Enter Cryptocurrency amount:"))
-        print("\n")
+        user_inp = input("\n\tEnter Your Choice Here : ")
+
         if user_inp == "1":
-            result = convert_crypto_to_currency(
-                amount, cryptocurrency, currency)
-            print(f"{amount} {cryptocurrency} in {currency} is {result}")
+            crypto_type = input("\nEnter the Cryptocurrency Type  :  ")
+            fiat_type = input("Enter the Fiat Money Type  :  ")
+            try: crypto_value = float(input("\nEnter the Cryptocurrency Value  :  "))
+            except:
+                print("Bad Input!\nPlease Enter \"y\" if you wish to continue, else \"n\".")
+                choice = input()
+                if choice == "y": continue
+                elif choice == "n": return
+                else:
+                    print("Bad Input Again!")
+                    return
+            result = convert_crypto_to_fiat(crypto_value, crypto_type.upper(), fiat_type.upper())
+            if result is None: return
+            elif result == 1: continue
+            print(f"{crypto_value} {crypto_type.upper()} in {fiat_type.upper()} is  -->  {result}")
+
         elif user_inp == "2":
-            result = convert_crypto_to_currency(
-                amount, cryptocurrency, currency)
-            print(f"{amount} {currency} in {cryptocurrency} is {result}")
-        elif user_inp == "Q":
-            break
+            fiat_type = input("\nEnter the Fiat Money Type  :  ")
+            crypto_type = input("Enter the Cryptocurrency Type  :  ")
+            try: fiat_value = float(input("\nEnter the Fiat Money Value  :  "))
+            except:
+                print("You did not enter a number!\nPlease Enter \"y\" if you wish to continue, else \"n\".")
+                choice = input()
+                if choice == "y": continue
+                elif choice == "n": return
+                else:
+                    print("Bad Input Again!")
+                    return
+            result = convert_fiat_to_crypto(fiat_value, fiat_type.upper(), crypto_type.upper())
+            if result is None: return
+            elif result == 1: continue
+            print(f"{fiat_value} {fiat_type.upper()} in {crypto_type.upper()} is  -->  {result}")
+        
+        elif user_inp == "Q" or user_inp == "q": return
+
         else:
-            print("Wrong Input! try again")
+            print("\nYour Input was NOT in the choices. Try again later.\n")
+            return
+
+
+if __name__ == "__main__":
+    """The driver code."""
+    info_msg = """
+We convert currency -> Cryptocurrency to Fiat Money and vice-versa.\n\n
+Possible Cryptocurrencies available for conversion are : 
+\t BTC  :  Bitcoin
+\t ETH  :  Ethereum.
+\t ETC  :  Ethereum Classic
+\t BCH  :  Bitcoin Cash
+\t LTC  :  Litecoin
+\t ZEC  :  Zcash
+\t ZRX  :  Ox\n\n
+Press (1)  :  To convert Cryptocurrency to Fiat Money.
+Press (2)  :  To convert Fiat Money to Cryptocurrency.
+Press (Q/q)  :  If you're wanting to Quit
+"""
+    print(info_msg)
+    stat = main()
+    if stat is not None:
+        print(stat)
+