Can i join the cpp and lua templates?

[paulocoutinhox]

Hi,

Can i join the cpp and lua templates?

I need to know if it's in your interest before making the pull-request and then getting rejected and investing time in it.

I can do?

[aismann]

Can i join the cpp and lua templates?
I need to know if it's in your interest before making the pull-request and then getting rejected and investing time in it.
I can do?

As @rh101 has written sometimes before:

We have to be careful when making changes to the template. 
The template should remain as simple as possible, and not just adds "noise" or your own stuff to the code.

And:

The template is meant as a starting point, and that file will be edited during your development process. 
The developer of a project can easily add or delete any code they want to it.

[iAndyHD3]

Say what you would like to change so it can be discussed first to avoid wasted effort

[rh101]

While the templates do have similarities, they are not the same. The LUA template has a lot of modifications and extra files that are specific to LUA, and would cause problems with projects not using LUA.

Merging them together would add a lot of work for developers who do not use LUA, forcing them to clean up the generated project before they can even start their own work.

It makes no sense to merge them whatsoever.

[paulocoutinhox]

Hi,

I said that i want join the template, don't change anything.

I think that will be more easy keep a single template, since they share most things.

The only files that have lua specific things is "AppDelegate.cpp" and "CMakeLists.txt" that i can have two and keep only one after project generation.

Files not used by selected template will be automatically removed, like it is done today inside "axproj-template.json", it solve the problem of have only needly files for that template.

[aismann]

I think that will be more easy keep a single template, since they share most things.

What about the future?
Will C++/Lua template be the same?
I think the improvement will be not so much.

[rh101]

If you can ensure that the CPP projects generated from that single template will be exactly as they are now (meaning no LUA related items in the CPP project), then yes, it would be reasonable to merge them. You would also have to ensure that merging them isn't going to add an extra level of complexity to maintaining the template.

[paulocoutinhox]

Merging projects does not mean that they will have both codes in the final project generated by the tool, but that we will have a single template to maintain. Obviously, the final code will be what we have today, but I don't need to say that this will be the case, right?

[rh101]

Obviously, the final code will be what we have today, but I don't need to say that this will be the case, right?

No, everything should always be stated plainly. If a proposal is put forward to make changes, then it is always best to be clear about why the changes are being made, and what impact they may have. In this case, stating that the modifications to the template would not impact the generated projects may have been enough to avoid all of this back and forth discussion.

[aismann]

But anyhow:
@paulocoutinhox
Let see what you want improve (not change!)

[paulocoutinhox]

What we will gain from this is in terms of maintenance. Today, people only change the cpp-template code and not the Lua template, leaving the codes different. We have to change/add images for the two templates that have the same images and xcode things, for example. Basically our work is doubled, and can be reduced to a single job, and this is something you haven't realized yet. If we only have one place to tinker, the rework is cut out and we can move forward better by tinkering with a single project.

[aismann]

and this is something you haven't realized yet

@paulocoutinhox
Belive me, we known it. Make a PR and let see.

[aismann]

@paulocoutinhox
Can it (you) close?