code-style: Fix/c headers (#3214)

* refactor: replace <c*> headers with C headers, remove std:: prefix

- <cassert> -> <assert.h>, <cctype> -> <ctype.h>, <cfloat> -> <float.h>, <cstdint> -> <stdint.h>, <cstdlib> -> <stdlib.h>, <cstring> -> <string.h>

- Remove <cstddef> includes (available transitively)

- Remove std:: prefix from non-math C types/functions globally

- <cmath> exempted (C++ overloaded math); std::nullptr_t and std::abs preserved

- Add check-cstd-inc.ps1 for CI and C++ Wrapper C Headers rule to CODING_STYLE.md
* Add ci
* fix: restore std:: prefix for std::remove algorithm calls
- 3 occurrences in ProgramState.cpp and Console.cpp were incorrectly stripped
* Cleanup code

Author: halx99

.github/workflows/check-cstd-headers.yml

@@ -0,0 +1,27 @@
+name: check-cstd-headers
+
+on:
+  pull_request:
+    paths:
+      - 'axmol/**'
+      - 'extensions/**'
+  push:
+    branches:
+      - dev*
+      - release/*
+    paths:
+      - 'axmol/**'
+      - 'extensions/**'
+      - 'tests'
+      - 'templates'
+  workflow_dispatch:
+
+jobs:
+  check-cstd-headers:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v6
+
+    - name: Check for forbidden C++ wrapper C headers
+      shell: pwsh
+      run: ./tools/cmdline/check-cstd-inc.ps1

axmol/2d/ActionTiledGrid.cpp

@@ -277,7 +277,7 @@ void ShuffleTiles::startWithTarget(Node* target)
 
     if (_seed != (unsigned int)-1)
     {
-        std::srand(_seed);
+        srand(_seed);
     }
 
     _tilesCount = (unsigned int)(_gridSize.width * _gridSize.height);
@@ -603,7 +603,7 @@ void TurnOffTiles::startWithTarget(Node* target)
 
     if (_seed != (unsigned int)-1)
     {
-        std::srand(_seed);
+        srand(_seed);
     }
 
     _tilesCount = (unsigned int)(_gridSize.width * _gridSize.height);

axmol/2d/Label.cpp

@@ -3200,7 +3200,7 @@ void Label::recordLetterInfo(const ax::Vec2& point,
                              float offsetX,
                              float offsetY)
 {
-    if (static_cast<std::size_t>(letterIndex) >= _lettersInfo.size())
+    if (static_cast<size_t>(letterIndex) >= _lettersInfo.size())
     {
         LetterInfo tmpInfo;
         _lettersInfo.emplace_back(tmpInfo);
@@ -3217,7 +3217,7 @@ void Label::recordLetterInfo(const ax::Vec2& point,
 
 void Label::recordPlaceholderInfo(int letterIndex, char32_t utf32Char)
 {
-    if (static_cast<std::size_t>(letterIndex) >= _lettersInfo.size())
+    if (static_cast<size_t>(letterIndex) >= _lettersInfo.size())
     {
         LetterInfo tmpInfo;
         _lettersInfo.emplace_back(tmpInfo);

axmol/3d/ObjLoader.cpp

@@ -22,11 +22,10 @@
  THE SOFTWARE.
  ****************************************************************************/
 
-#include <cstdlib>
-#include <cstring>
-#include <cassert>
+#include <stdlib.h>
+#include <string.h>
+#include <assert.h>
 #include <cmath>
-#include <cstddef>
 
 #include <string>
 #include <vector>
@@ -666,7 +665,7 @@ std::string LoadMtl(tlx::string_map<int>& material_map, std::vector<material_t>&
         }
         if (_space)
         {
-            std::ptrdiff_t len = _space - token;
+            ptrdiff_t len = _space - token;
             std::string key(token, len);
             std::string value = _space + 1;
             material.unknown_parameter.emplace(std::move(key), std::move(value));

axmol/base/Console.cpp

@@ -30,7 +30,7 @@
 #include <thread>
 #include <algorithm>
 #include <functional>
-#include <cctype>
+#include <ctype.h>
 #include <locale>
 #include <sstream>
 #include <optional>
@@ -1138,7 +1138,7 @@ void Console::commandTouchSubCommandTap(socket_native_type fd, std::string_view
 
     if (argi == 3)
     {
-        std::srand((unsigned)time(nullptr));
+        srand((unsigned)time(nullptr));
         _touchId = rand();
         Director::getInstance()->postTask([this, x, y]() {
             PointerInputState pointerDownData{.id = _touchId};
@@ -1176,15 +1176,15 @@ void Console::commandTouchSubCommandSwipe(socket_native_type fd, std::string_vie
             //     return;
             // }
             char* endptr = nullptr;
-            points[i]    = std::strtod(val.data(), &endptr);
+            points[i]    = strtod(val.data(), &endptr);
         }
 
         float& x1 = points[0];
         float& y1 = points[1];
         float& x2 = points[2];
         float& y2 = points[3];
 
-        std::srand((unsigned)time(nullptr));
+        srand((unsigned)time(nullptr));
         _touchId = rand();
 
         Director::getInstance()->postTask([x1, y1, this]() {

axmol/base/InputSystem.cpp

@@ -33,7 +33,7 @@ THE SOFTWARE.
 #include "axmol/scene/Camera.h"
 
 #include <list>
-#include <cfloat>
+#include <float.h>
 #include <map>
 
 // Touch bookkeeping was migrated into InputSystem private members.

axmol/base/Properties.h

@@ -25,7 +25,7 @@
 
 #include <string>
 #include <functional>
-#include <cstdint>
+#include <stdint.h>
 #include <vector>
 
 #include "axmol/renderer/Texture2D.h"

axmol/base/Random.h

@@ -27,7 +27,7 @@ THE SOFTWARE.
 #pragma once
 
 #include <random>
-#include <cstdlib>
+#include <stdlib.h>
 
 #include "axmol/platform/PlatformConfig.h"
 
@@ -104,25 +104,25 @@ inline int random()
     return ax::random(0, AX_RAND_MAX);
 };
 
-/// Follow random APIs is device independent,  need set seed by std::srand
+/// Follow random APIs is device independent,  need set seed by srand
 /// DEPRECATED: use FastRGN.h or c++11 'std::minstd_rand' or 'std::minstd_rand0' instead
 
 /**
  * Returns a random float between -1 and 1.
- * It can be seeded using std::srand(seed);
+ * It can be seeded using srand(seed);
  */
 inline float rand_minus1_1()
 {
-    return ((std::rand() / (float)RAND_MAX) * 2) - 1;
+    return ((rand() / (float)RAND_MAX) * 2) - 1;
 }
 
 /**
  * Returns a random float between 0 and 1.
- * It can be seeded using std::srand(seed);
+ * It can be seeded using srand(seed);
  */
 inline float rand_0_1()
 {
-    return std::rand() / (float)RAND_MAX;
+    return rand() / (float)RAND_MAX;
 }
 
 }  // namespace ax

axmol/base/Utils.cpp

@@ -902,7 +902,7 @@ namespace braceinit
 {
 inline void skip_ws(const char*& p, const char* end)
 {
-    while (p < end && std::isspace(static_cast<unsigned char>(*p)))
+    while (p < end && isspace(static_cast<unsigned char>(*p)))
         ++p;
 }
 inline bool expect(const char*& p, const char* end, char c)

axmol/base/Utils.h

@@ -113,7 +113,7 @@ AX_DLL std::vector<Node*> findChildren(const Node& node, std::string_view name);
 #
 
 /** Same to ::atof, but strip the string, remain 7 numbers after '.' before call atof.
- * Why we need this? Because in android c++_static, atof ( and std::atof ) is unsupported for numbers have long decimal
+ * Why we need this? Because in android c++_static, atof ( and atof ) is unsupported for numbers have long decimal
  * part and contain several numbers can approximate to 1 ( like 90.099998474121094 ), it will return inf. This function
  * is used to fix this bug.
  * @param str The string be to converted to double.