Skip to content

Commit 8c9f41a

Browse files
committed
adress the review comments
1 parent 349a5d5 commit 8c9f41a

File tree

4 files changed

+124
-36
lines changed

4 files changed

+124
-36
lines changed

libraries/src/AWS.Lambda.Powertools.Parameters/AWS.Lambda.Powertools.Parameters.csproj

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,14 @@
77
</PropertyGroup>
88

99
<ItemGroup>
10-
<PackageReference Include="AWSSDK.AppConfigData" Version="3.7.0.110" />
11-
<PackageReference Include="AWSSDK.DynamoDBv2" Version="3.7.5.10" />
12-
<PackageReference Include="AWSSDK.SecretsManager" Version="3.7.2.88" />
13-
<PackageReference Include="AWSSDK.SimpleSystemsManagement" Version="3.7.18.2" />
14-
<PackageReference Include="Microsoft.Extensions.Configuration" Version="6.0.1" />
10+
<PackageReference Include="AWSSDK.DynamoDBv2" Version="3.7.103.1" />
11+
<PackageReference Include="AWSSDK.SecretsManager" Version="3.7.102.38" />
12+
<PackageReference Include="AWSSDK.SimpleSystemsManagement" Version="3.7.104.29" />
13+
<PackageReference Include="Microsoft.Extensions.Configuration" Version="7.0.0" />
14+
</ItemGroup>
15+
16+
<ItemGroup>
17+
<ProjectReference Include="..\AWS.Lambda.Powertools.Common\AWS.Lambda.Powertools.Common.csproj" />
1518
</ItemGroup>
1619

1720
</Project>

libraries/src/AWS.Lambda.Powertools.Parameters/Internal/Provider/ParameterProviderBaseHandler.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
* permissions and limitations under the License.
1414
*/
1515

16+
using AWS.Lambda.Powertools.Common;
1617
using AWS.Lambda.Powertools.Parameters.Cache;
1718
using AWS.Lambda.Powertools.Parameters.Configuration;
1819
using AWS.Lambda.Powertools.Parameters.Internal.Cache;
@@ -89,15 +90,18 @@ internal class ParameterProviderBaseHandler : IParameterProviderBaseHandler
8990
/// <param name="getAsyncHandler">The parameter provider GetAsync callback handler.</param>
9091
/// <param name="getMultipleAsyncHandler">The parameter provider GetMultipleAsync callback handler.</param>
9192
/// <param name="cacheMode">The CacheMode.</param>
93+
/// <param name="powertoolsConfigurations">The Powertools configurations.</param>
9294
internal ParameterProviderBaseHandler(GetAsyncDelegate getAsyncHandler,
9395
GetMultipleAsyncDelegate getMultipleAsyncHandler,
94-
ParameterProviderCacheMode cacheMode)
96+
ParameterProviderCacheMode cacheMode,
97+
IPowertoolsConfigurations powertoolsConfigurations)
9598
{
9699
_getAsyncHandler = getAsyncHandler;
97100
_getMultipleAsyncHandler = getMultipleAsyncHandler;
98101
_cacheMode = cacheMode;
102+
powertoolsConfigurations.SetExecutionEnvironment(this);
99103
}
100-
104+
101105
/// <summary>
102106
/// Try transform a value using a transformer.
103107
/// </summary>

libraries/src/AWS.Lambda.Powertools.Parameters/Provider/ParameterProvider.cs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
* permissions and limitations under the License.
1414
*/
1515

16+
using AWS.Lambda.Powertools.Common;
1617
using AWS.Lambda.Powertools.Parameters.Cache;
1718
using AWS.Lambda.Powertools.Parameters.Transform;
1819
using AWS.Lambda.Powertools.Parameters.Configuration;
@@ -25,7 +26,7 @@ namespace AWS.Lambda.Powertools.Parameters.Provider;
2526
/// </summary>
2627
public abstract class ParameterProvider : IParameterProvider
2728
{
28-
/// <summary>
29+
/// <summary>
2930
/// The parameter provider handler instance.
3031
/// </summary>
3132
private IParameterProviderBaseHandler? _handler;
@@ -34,7 +35,12 @@ public abstract class ParameterProvider : IParameterProvider
3435
/// Gets parameter provider handler instance.
3536
/// </summary>
3637
internal IParameterProviderBaseHandler Handler =>
37-
_handler ??= new ParameterProviderBaseHandler(GetAsync, GetMultipleAsync, CacheMode);
38+
_handler ??= new ParameterProviderBaseHandler(
39+
GetAsync,
40+
GetMultipleAsync,
41+
CacheMode,
42+
PowertoolsConfigurations.Instance
43+
);
3844

3945
/// <summary>
4046
/// Gets the CacheManager instance.

0 commit comments

Comments
 (0)