Skip to content

Investigate improvement in JSON huge payload #1993

Open
@sebastienros

Description

@sebastienros

image

Activity

BrennanConroy

BrennanConroy commented on Jun 3, 2024

@BrennanConroy
Member

Narrowed this down to dotnet/runtime@8f2f3da...010a744
Which is the Json change that shouldn't really affect too much yet 😆

sebastienros

sebastienros commented on Jun 3, 2024

@sebastienros
MemberAuthor

But it's also regression workingset/allocations, is that expected? #1994

BrennanConroy

BrennanConroy commented on Jun 3, 2024

@BrennanConroy
Member

Haven't looked at that one yet.

BrennanConroy

BrennanConroy commented on Jun 3, 2024

@BrennanConroy
Member

Allocations are all from PooledByteBufferWriter. I think we basically doubled the size of it by adding a Stream field to it, and making it inherit from PipeWriter which has a private Stream field as well. So it went from int and byte[], to int, byte[], Stream, Stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Investigate improvement in JSON huge payload · Issue #1993 · aspnet/Benchmarks