Enhance traybar icons (#857)

* add new icons (with border and filled), remove macos for light theme

* remove dark mode detection (it was not working)

* remove build tag and use file suffix for conditional build

* Use `SetIconTemplate`, this allows theme switching on macos

* partially revert 0444f2a

Macos needs transparent icon to apply templating

* rework icons:

 macos icons have been re-exported (to the correct size/color/opacity)
 windows icons have been re-exported from the linux ones (with the border)

 added also two svg files that should allow working on the icon easier in the future

Author: umbynos

icon/icon.svg

@@ -0,0 +1,23 @@
+package icon
+
+import _ "embed" // import embed to embed the icon
+
+// GetIcon will return the icon
+func GetIcon() []byte {
+	return data
+}
+
+// GetIconHiber will return the hibernated icon
+func GetIconHiber() []byte {
+	return dataHibernate
+}
+
+// data represents the icon
+//
+//go:embed icon_mac.png
+var data []byte
+
+// dataHibernate represents the icon hibernated
+//
+//go:embed icon_mac_hiber.png
+var dataHibernate []byte

icon/icon_darwin.go

@@ -1,5 +1,3 @@
-//go:build linux
-
 package icon
 
 import _ "embed" // import embed to embed the icon

icon/icon_hiber.svg

@@ -1,5 +1,3 @@
-//go:build windows
-
 package icon
 
 import _ "embed" // import embed to embed the icon

icon/iconlinux.go renamed to icon/icon_linux.go

@@ -50,7 +50,7 @@ func (s *Systray) Quit() {
 
 // start creates a systray icon with menu options to go to arduino create, open debug, pause/quit the agent
 func (s *Systray) start() {
-	systray.SetIcon(icon.GetIcon())
+	systray.SetTemplateIcon(icon.GetIcon(), icon.GetIcon())
 
 	// Add version
 	menuVer := systray.AddMenuItem("Agent version "+s.Version, "")
@@ -136,7 +136,7 @@ func RemoveCrashes() {
 
 // starthibernate creates a systray icon with menu options to resume/quit the agent
 func (s *Systray) startHibernate() {
-	systray.SetIcon(icon.GetIconHiber())
+	systray.SetTemplateIcon(icon.GetIconHiber(), icon.GetIconHiber())
 
 	mResume := systray.AddMenuItem("Resume Agent", "")
 	systray.AddSeparator()