refactor: clean up serialport.go and serialportlist.go for clarity

dido18 · dido18 · commit 283064c82eba · 2025-04-02T16:15:15.000+02:00
diff --git a/serialport.go b/serialport.go
@@ -240,7 +240,10 @@ func (p *serport) writerNoBuf() {
 	p.OnMessage([]byte(msgstr))
 
 	p.portIo.Close()
-	// serialPorts.List(
+
+	// The effect of this call is to send in to all the we client the list of serial ports
+	// TODO: investigate if this is superfluous and it can be removed.
+	// serialPorts.List()
 
 }
 
diff --git a/serialportlist.go b/serialportlist.go
@@ -12,11 +12,10 @@ import (
 )
 
 type serialPortList struct {
-	tools *tools.Tools
-
 	Ports     []*SpPortItem
 	portsLock sync.Mutex
 
+	tools  *tools.Tools `json:"-"`
 	OnList func([]byte) `json:"-"`
 	OnErr  func(string) `json:"-"`
 }

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,10 @@ func (p *serport) writerNoBuf() {`
`240`	`240`	`p.OnMessage([]byte(msgstr))`
`241`	`241`
`242`	`242`	`p.portIo.Close()`
`243`		`- // serialPorts.List(`
	`243`	`+`
	`244`	`+ // The effect of this call is to send in to all the we client the list of serial ports`
	`245`	`+ // TODO: investigate if this is superfluous and it can be removed.`
	`246`	`+ // serialPorts.List()`
`244`	`247`
`245`	`248`	`}`
`246`	`249`