Expose golang fqbn package for public use (#2768)

* Made FQBN parsing package public

Because it may turn out useful for other projects.

* 100% test coverage

* Precompile validation regexp

* Remove logrus dependency from i18n

* Isolate locale-handling functions from i18n interface

This changes allows to make a clean i18n package (without dependency on
a specific implementation of the translation package) that, in turn,
allows to export packages that internally use i18n with the minimal
dependency load.

* updated doc

Author: cmaglie

Taskfile.yml

@@ -309,24 +309,24 @@ tasks:
   i18n:update:
     desc: Updates i18n files
     cmds:
-      - go run ./internal/i18n/cmd/main.go catalog generate . > ./internal/i18n/data/en.po
+      - go run ./internal/locales/cmd/main.go catalog generate . > ./internal/locales/data/en.po
 
   i18n:pull:
     desc: Pull i18n files from transifex
     cmds:
-      - go run ./internal/i18n/cmd/main.go transifex pull ./internal/i18n/data
+      - go run ./internal/locales/cmd/main.go transifex pull ./internal/locales/data
 
   i18n:push:
     desc: Push i18n files to transifex
     cmds:
-      - go run ./internal/i18n/cmd/main.go transifex push ./internal/i18n/data
+      - go run ./internal/locales/cmd/main.go transifex push ./internal/locales/data
 
   i18n:check:
     desc: Check if the i18n message catalog was updated
     cmds:
       - task: i18n:pull
-      - git add -N ./internal/i18n/data
-      - git diff --exit-code ./internal/i18n/data
+      - git add -N ./internal/locales/data
+      - git diff --exit-code ./internal/locales/data
 
   # Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-mkdocs-task/Taskfile.yml
   website:check:

commands/instances.go

@@ -38,6 +38,7 @@ import (
 	"github.com/arduino/arduino-cli/internal/arduino/sketch"
 	"github.com/arduino/arduino-cli/internal/arduino/utils"
 	"github.com/arduino/arduino-cli/internal/i18n"
+	"github.com/arduino/arduino-cli/internal/locales"
 	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
 	paths "github.com/arduino/go-paths-helper"
 	"github.com/sirupsen/logrus"
@@ -420,7 +421,7 @@ func (s *arduinoCoreServerImpl) Init(req *rpc.InitRequest, stream rpc.ArduinoCor
 	// language of the CLI if the locale is different
 	// after started.
 	if locale, ok, _ := s.settings.GetStringOk("locale"); ok {
-		i18n.Init(locale)
+		locales.Init(locale)
 	}
 
 	return nil