Add serial number of connected board to board list command (#1216)

* Add serial number of connected board to board details command

* Moved serial number from board details to board list

Author: silvanocerza

cli/board/list.go

@@ -109,6 +109,7 @@ func watchList(cmd *cobra.Command, inst *rpc.Instance) {
 			Protocol:      event.Port.Protocol,
 			ProtocolLabel: event.Port.ProtocolLabel,
 			Boards:        event.Port.Boards,
+			SerialNumber:  event.Port.SerialNumber,
 			Error:         event.Error,
 		})
 	}
@@ -181,6 +182,7 @@ type watchEvent struct {
 	Protocol      string               `json:"protocol,omitempty"`
 	ProtocolLabel string               `json:"protocol_label,omitempty"`
 	Boards        []*rpc.BoardListItem `json:"boards,omitempty"`
+	SerialNumber  string               `json:"serial_number,omitempty"`
 	Error         string               `json:"error,omitempty"`
 }
 

commands/board/list.go

@@ -185,6 +185,7 @@ func List(instanceID int32) (r []*rpc.DetectedPort, e error) {
 			Protocol:      port.Protocol,
 			ProtocolLabel: port.ProtocolLabel,
 			Boards:        boards,
+			SerialNumber:  port.Prefs.Get("serialNumber"),
 		}
 		retVal = append(retVal, p)
 	}
@@ -222,13 +223,19 @@ func Watch(instanceID int32, interrupt <-chan bool) (<-chan *rpc.BoardListWatchR
 					}
 				}
 
+				serialNumber := ""
+				if props := event.Port.Properties; props != nil {
+					serialNumber = props.Get("serialNumber")
+				}
+
 				outChan <- &rpc.BoardListWatchResp{
 					EventType: event.Type,
 					Port: &rpc.DetectedPort{
 						Address:       event.Port.Address,
 						Protocol:      event.Port.Protocol,
 						ProtocolLabel: event.Port.ProtocolLabel,
 						Boards:        boards,
+						SerialNumber:  serialNumber,
 					},
 					Error: boardsError,
 				}

go.sum

@@ -285,6 +285,7 @@ golang.org/x/crypto v0.0.0-20200406173513-056763e48d71/go.mod h1:LzIPMQfyMNhhGPh
 golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
 golang.org/x/lint v0.0.0-20181026193005-c67002cb31c3/go.mod h1:UVdnD1Gm6xHRNCYTkRU2/jEulfH38KcIWyp/GAMgvoE=
 golang.org/x/lint v0.0.0-20190227174305-5b3e6a55c961/go.mod h1:wehouNa3lNwaWXcvxsM5YxQ5yQlVC4a0KAMCusXpPoU=
+golang.org/x/lint v0.0.0-20190313153728-d0100b6bd8b3 h1:XQyxROzUlZH+WIQwySDgnISgOivlhjIEwaQaJEJrrN0=
 golang.org/x/lint v0.0.0-20190313153728-d0100b6bd8b3/go.mod h1:6SW0HCj/g11FgYtHlgUYUwCkIfeOF89ocIRzGO/8vkc=
 golang.org/x/net v0.0.0-20180406214816-61147c48b25b/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
 golang.org/x/net v0.0.0-20180724234803-3673e40ba225/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=

rpc/commands/board.pb.go

@@ -59,6 +59,8 @@ message BoardDetailsResp {
     repeated Programmer programmers = 13;
     // Set to true if the board supports debugging
     bool debugging_supported = 14;
+    // If a board with the specified FQBN is connected returns its serial number too
+    string serialNumber = 15;
 }
 
 message IdentificationPref {
@@ -192,6 +194,8 @@ message DetectedPort {
     string protocol_label = 3;
     // The boards attached to the port.
     repeated BoardListItem boards = 4;
+    // Serial number of connected board
+    string serial_number = 5;
 }
 
 message BoardListAllReq {