Stop compilation on the first error, and highlight it first

[cunidev]

Highlighting the latest code syntax error makes it more difficult to find the line of code causing problems...

Example:

Class classname();
classname.doThis(); <--- # 1
classname.doThat();
classname.doThatAgain(); <--- this line is highlighted in case of error, instead of # 1

I don't know if I'm clear... Thanks

[matthijskooijman]

I guess the best solution would be to highlight all errors, and jump to / focus the first one? Agreed that the last error isn't typically the one to look at and the first error is.

[cunidev]

Yes, my solution was only if it wasn't possible to highlight all. Of course
all lines highlighted would be better.
Il 31/ago/2015 22:31, "Matthijs Kooijman" notifications@github.com ha
scritto:

I guess the best solution would be to highlight all errors, and jump to
/ focus the first one? Agreed that the last error isn't typically the one
to look at and the first error is.

—
Reply to this email directly or view it on GitHub
#3748 (comment).

[mikaelpatel]

A simple solution is to use the extra_flags variables in platform.txt and add the gcc compiler option -Wfatal-errors

This option causes the compiler to abort compilation on the first error occurred rather than trying to keep going and printing further error messages.

The platform variables to change are:
compiler.c.extra_flags=-Wfatal-errors
compiler.cpp.extra_flags=-Wfatal-errors

This could be nice for beginners.

Ref. 1. https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html

[cunidev]

Thanks for the answer. Would it be possible to suggest this changes via a
pull request then, or would there be any drawbacks? (There shouldn't be any
in my opinion)
Il 31/ago/2015 23:20, "Mikael Patel" notifications@github.com ha scritto:

A simple solution is to use the extra_flags variables in platform.txt and
add the gcc compiler option -Wfatal-errors

This option causes the compiler to abort compilation on the first error
occurred rather than trying to keep going and printing further error
messages.

The platform variables to change are:
compiler.c.extra_flags=-Wfatal-errors
compiler.cpp.extra_flags=-Wfatal-errors

This could be nice for beginners.

Ref. 1. https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html

—
Reply to this email directly or view it on GitHub
#3748 (comment).

[q2dg]

+1 for pull request. It's an obvious improvement

[matthijskooijman]

Having more than one error shown can make things more efficient, though, -Wfatal-errors means you can only look at and fix one error at a time (though that might be easiest for novice users, perhaps?).

Perhaps something to discuss on the mailing list?

[cunidev]

Well, as the code is read by the compiler from the first to the last line, it's not that useful IMHO to see all the errors, because they are usually caused by the first error (like in the first example). Otherwise, it would still be necessary to solve the first error first. Try to remove a simple semicolon: the compiler will probably highlight the last line of the sketch. Pretty useless, isn't it?
I'd insert -Wfatal-errors as default, and in case allow to disable it...

[shiftleftplusone]

I agree to matthijskooijman:
"
I guess the best solution would be to highlight all errors, and jump to / focus the first one? ...
"

Additionally, jumping to the related errors in the source code by double-click on either error listed in the debug window would be very helpful though.

[matthijskooijman]

Well, as the code is read by the compiler from the first to the last line, it's not that useful IMHO to see all the errors, because they are usually caused by the first error (like in the first example). Otherwise, it would still be necessary to solve the first error first. Try to remove a simple semicolon: the compiler will probably highlight the last line of the sketch.

That is true, but consider other errors too: a typo in function name, a wrong number of arguments to a function, etc. These will not break the syntax and usually not introduce any additional errors, making any errors beyond the first real errors too.

[shiftleftplusone]

so I'd suggest to implement the list-all-errors-and-at-double-click-then-jump-to-related-source-code-line feature

[Chris--A]

Jumping to a line on click seems like a valuable addition. I would probably find having only one error at a time very frustrating.

[NicoHood]

I also dont like a single error. But what about an option in preferences? Similar to the Warning setting you could stop on the first error here.

Jumping to the first error could be an idea though.