Don't ack within 'read' if we are having a callback registered and reading from within the callback

aentinger · aentinger · commit e344a37dd1ff · 2020-07-28T15:48:34.000+02:00
diff --git a/src/MqttClient.cpp b/src/MqttClient.cpp
@@ -713,7 +713,9 @@ int MqttClient::read(uint8_t *buf, size_t size)
       _rxLength -= result;
 
       if (_rxLength == 0) {
-        ackRxMessage();
+        if (!_onMessage) {
+          ackRxMessage();
+        }
 
         _rxState = MQTT_CLIENT_RX_STATE_READ_TYPE;
       }

Original file line number	Diff line number	Diff line change
`@@ -713,7 +713,9 @@ int MqttClient::read(uint8_t *buf, size_t size)`
`713`	`713`	`_rxLength -= result;`
`714`	`714`
`715`	`715`	`if (_rxLength == 0) {`
`716`		`- ackRxMessage();`
	`716`	`+ if (!_onMessage) {`
	`717`	`+ ackRxMessage();`
	`718`	`+ }`
`717`	`719`
`718`	`720`	`_rxState = MQTT_CLIENT_RX_STATE_READ_TYPE;`
`719`	`721`	`}`