You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@JAndrassy thank you for communicating your concerns above in: ade2940#commitcomment-35852164. I've created pull request #22 to address, we would appreciate your feedback on it.
9 commit comments
JAndrassy commentedon Nov 5, 2019
you updated to old esp8266 core?
esp8266/Arduino@cdb5495#diff-6b1b07c053c3e5f501aa2b480d825226
https://stackoverflow.com/questions/58704904/how-do-i-let-the-compiler-know-which-virtual-to-use-from-the-imported-library
aentinger commentedon Nov 5, 2019
Unfortunately necessary because Arduino Create uses 2.5.0.
JAndrassy commentedon Nov 6, 2019
but it doesn't compile for SAMD Arduino then. add some ifdefs
aentinger commentedon Nov 7, 2019
Since you are already at it would you mind to prepare a PR?
JAndrassy commentedon Nov 7, 2019
I don't use this library. I only helped with a question linked in my first comment
aentinger commentedon Nov 7, 2019
So you know for sure it doesn't compile for SAMD?
JAndrassy commentedon Nov 7, 2019
uff, only now I see this is the official Arduino repository and the library is targeted for SAMD.
the esp8266 maintainers corrected the Client API on my hassle and here this.
so it is very easy to take the WiFiSimpleSender example, change the broker to IPAddress and get the error
aentinger commentedon Nov 11, 2019
Thx for resolving the issue on ESP core side. I wish we could do without this change but unfortunately as I've outlined above we can't. @eclipse1985 .
sandeepmistry commentedon Nov 14, 2019
@JAndrassy thank you for communicating your concerns above in: ade2940#commitcomment-35852164. I've created pull request #22 to address, we would appreciate your feedback on it.