Enable tagalign rule in golangci-lint
#4369
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shion1305
commented
Dec 1, 2025
| t.Fatal("rt.GOOS is empty") | ||
| } | ||
| if rt.GOARCH == "" { | ||
| if rt.GOARCH == "" { //nolint:staticcheck |
Contributor
Author
There was a problem hiding this comment.
I noticed some lint errors here, so I've added nolint annotations. lmk what you think
Contributor
Author
There was a problem hiding this comment.
Weird... test-ci is currently failing on these annotations but running local does not give me any errors 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Require signed commits, so all commits must be signedThis PR enables
tagalignrule in golangci-lint, which enables us to unify ordering of struct tags.Currently ordering of
yamlorjsontags are not consistent, I felt we can benefit from this linting rule.Closes: #4368