Skip to content

Conversation

@heri16
Copy link

@heri16 heri16 commented Nov 19, 2025

Check List

Enable github_artifact_attestations for foundry-rs/foundry

@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

format: zip
github_artifact_attestations:
signer_workflow: foundry-rs/foundry/.github/workflows/release.yml
- version_constraint: semver("< 1.3.0-rc1")
Copy link
Member

@suzuki-shunsuke suzuki-shunsuke Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 I'm looking into the version which they started to release attestations from.

Image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you set 1.3.0-rc1?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attestations were not fully enabled until 1.3.0-rc1. You can confirm this through the missing attestation artifacts in GitHub’s release page.

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Nov 19, 2025

The verification failed.

Error: HTTP 404: Not Found (https://api.github.com/repos/foundry-rs/foundry/attestations/sha256:f7cb873a296f08a61349b9a9114c3a0c171a1d33e4018f64ac21b7fa7c3ee9d7?per_page=30&predicate_type=https://slsa.dev/provenance/v1)

WARN[0007] execute gh attestation verify
args="attestation verify /tmp/887486218 -R foundry-rs/foundry --signer-workflow foundry-rs/foundry/.github/workflows/release.yml"
env=linux/arm64
error="exit status 1"
exe=/home/runner/.local/share/aquaproj-aqua/pkgs/github_release/github.com/cli/cli/v2.82.1/gh_2.82.1_linux_arm64.tar.gz/gh_2.82.1_linux_arm64/bin/gh 
package_name=foundry-rs/foundry
package_version=v1.4.4
program=aqua program_version=2.55.1 registry=standard

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Nov 19, 2025

I see. aqua can't verify their attestations because foundry create attestations of executable binaries instead of archive files (tarball and zip).
aqua verifies archive files, so the verification fails.

v1.4.4 https://github.com/foundry-rs/foundry/attestations/12664565

image

https://github.com/foundry-rs/foundry/blob/2f09f9a63dcb23907c560ceb0c06558835f10276/.github/workflows/release.yml#L261-L269

@heri16
Copy link
Author

heri16 commented Nov 21, 2025

I see. aqua can't verify their attestations because foundry create attestations of executable binaries instead of archive files (tarball and zip). aqua verifies archive files, so the verification fails.

v1.4.4 https://github.com/foundry-rs/foundry/attestations/12664565

https://github.com/foundry-rs/foundry/blob/2f09f9a63dcb23907c560ceb0c06558835f10276/.github/workflows/release.yml#L261-L269

I’m not sure I understand. What would be the way forward to verify foundry binaries that are downloaded by aqua? Wouldn’t attestation of binaries be functionally equivalent to archive attestation? Could the Checksum module be made to work if foundry repo don’t produce checksums?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants