-
-
Notifications
You must be signed in to change notification settings - Fork 233
Enable github_artifact_attestations for foundry-rs/foundry #44455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution! |
| format: zip | ||
| github_artifact_attestations: | ||
| signer_workflow: foundry-rs/foundry/.github/workflows/release.yml | ||
| - version_constraint: semver("< 1.3.0-rc1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you set 1.3.0-rc1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attestations were not fully enabled until 1.3.0-rc1. You can confirm this through the missing attestation artifacts in GitHub’s release page.
|
The verification failed. |
|
I see. aqua can't verify their attestations because foundry create attestations of executable binaries instead of archive files (tarball and zip). v1.4.4 https://github.com/foundry-rs/foundry/attestations/12664565
|
I’m not sure I understand. What would be the way forward to verify foundry binaries that are downloaded by aqua? Wouldn’t attestation of binaries be functionally equivalent to archive attestation? Could the Checksum module be made to work if foundry repo don’t produce checksums? |


Check List
Require signed commits, so all commits must be signedcmdx sto scaffold codeEnable github_artifact_attestations for
foundry-rs/foundry