Skip to content

Commit 7d111ee

Browse files
Merge pull request #68 from aquality-automation/feature/new_dashboard
Feature/new dashboard
2 parents f932005 + da15ea2 commit 7d111ee

File tree

5 files changed

+24
-18
lines changed

5 files changed

+24
-18
lines changed

src/main/java/main/controllers/Project/IssueController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public IssueController(UserDto user) {
3232
}
3333
@Override
3434
public List<IssueDto> get(IssueDto entity) throws AqualityException {
35-
if (baseUser.isManager() || baseUser.getProjectUser(entity.getProject_id()).isViewer()) {
35+
if (baseUser.isManager() || baseUser.isAuditAdmin() || baseUser.isAuditor() || baseUser.getProjectUser(entity.getProject_id()).isViewer()) {
3636
return fillIssues(issueDao.searchAll(entity));
3737
} else {
3838
throw new AqualityPermissionsException("Account is not allowed to view Issues", baseUser);

src/main/java/main/controllers/Project/TestRunController.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,21 @@ public TestRunDto getLastSuiteTestRun(Integer suiteId, Integer projectId) throws
8989

9090
@Override
9191
public boolean delete(TestRunDto template) throws AqualityException {
92-
if (baseUser.isManager() || baseUser.getProjectUser(template.getProject_id()).isEditor()) {
92+
if (baseUser.isManager() || baseUser.getProjectUser(template.getProject_id()).isAdminOrManager()) {
9393
return testRunDao.delete(template);
9494
} else {
9595
throw new AqualityPermissionsException("Account is not allowed to delete Test Run", baseUser);
9696
}
9797
}
9898

99+
public boolean delete(List<TestRunDto> template) throws AqualityException {
100+
if (baseUser.isManager() || baseUser.getProjectUser(template.get(0).getProject_id()).isAdminOrManager()) {
101+
return testRunDao.deleteMultiply(template);
102+
} else {
103+
throw new AqualityPermissionsException("Account is not allowed to delete Test Run", baseUser);
104+
}
105+
}
106+
99107
private void createPendingResults(TestRunDto testRunTemplate) throws AqualityException {
100108
TestDto testTemplate = new TestDto();
101109
testTemplate.setTest_suite_id(testRunTemplate.getTest_suite_id());

src/main/java/main/model/dto/project/ProjectUserDto.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,8 @@ public boolean isViewer(){
5050
public boolean isEditor() {
5151
return isAdmin() || isManager() || isEngineer();
5252
}
53+
54+
public boolean isAdminOrManager() {
55+
return isAdmin() || isManager();
56+
}
5357
}

src/main/java/main/view/BaseServlet.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,6 @@ protected void setPostResponseHeaders(@NotNull HttpServletResponse resp) {
8484
resp.addHeader("Access-Control-Allow-Methods", "Post");
8585
resp.addHeader("Access-Control-Allow-Origin", "*");
8686
resp.addHeader("Access-Control-Allow-Headers", "Authorization");
87-
resp.addHeader("Access-Control-Allow-Credentials", "true");
88-
resp.addHeader("Access-Control-Expose-Headers", "ErrorMessage");
89-
resp.addHeader("Access-Control-Allow-Headers", "ErrorMessage");
9087
}
9188

9289
protected void setEncoding(@NotNull HttpServletResponse resp) {
@@ -101,28 +98,20 @@ protected void setDeleteResponseHeaders(@NotNull HttpServletResponse resp) {
10198
resp.addHeader("Access-Control-Allow-Methods", "Delete");
10299
resp.addHeader("Access-Control-Allow-Origin", "*");
103100
resp.addHeader("Access-Control-Allow-Headers", "Authorization");
104-
resp.addHeader("Access-Control-Allow-Credentials", "true");
105-
resp.addHeader("Access-Control-Expose-Headers", "ErrorMessage");
106-
resp.addHeader("Access-Control-Allow-Headers", "ErrorMessage");
107101
}
108102

109103
protected void setGetResponseHeaders(@NotNull HttpServletResponse resp) {
110104
resp.addHeader("Access-Control-Allow-Methods", "Get");
111105
resp.addHeader("Access-Control-Allow-Origin", "*");
112106
resp.addHeader("Access-Control-Allow-Headers", "Authorization");
113-
resp.addHeader("Access-Control-Allow-Credentials", "true");
114-
resp.addHeader("Access-Control-Expose-Headers", "ErrorMessage");
115-
resp.addHeader("Access-Control-Allow-Headers", "ErrorMessage");
116107
resp.addHeader("Access-Control-Expose-Headers", "Content-Disposition");
117108
resp.addHeader("Access-Control-Allow-Headers", "Content-Disposition");
118109
}
119110

120111
protected void setOptionsResponseHeaders(@NotNull HttpServletResponse resp) {
121112
resp.addHeader("Access-Control-Allow-Methods", "GET, POST, OPTIONS, PUT, DELETE");
122113
resp.addHeader("Access-Control-Allow-Origin", "*");
123-
resp.addHeader("Access-Control-Allow-Headers", "Authorization, authorization, ErrorMessage, Disposition");
124-
resp.addHeader("Access-Control-Allow-Credentials", "true");
125-
resp.addHeader("Access-Control-Expose-Headers", "ErrorMessage");
114+
resp.addHeader("Access-Control-Allow-Headers", "Authorization, authorization, Disposition, Content-Type");
126115
resp.addHeader("Access-Control-Expose-Headers", "Content-Disposition");
127116
resp.setStatus(204);
128117
}

src/main/java/main/view/Project/TestRunServlet.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,15 @@ public void doDelete(HttpServletRequest req, HttpServletResponse resp) {
4444
setDeleteResponseHeaders(resp);
4545
try {
4646
Session session = createSession(req);
47-
TestRunDto testRun = new TestRunDto();
48-
testRun.setId(Integer.parseInt(req.getParameter("id")));
49-
testRun.setProject_id(getProjectId(req));
50-
session.controllerFactory.getHandler(testRun).delete(testRun);
47+
String requestedJson = getRequestJson(req);
48+
if(requestedJson == null || requestedJson.isEmpty()) {
49+
TestRunDto testRun = new TestRunDto();
50+
testRun.getSearchTemplateFromRequestParameters(req);
51+
session.controllerFactory.getHandler(testRun).delete(testRun);
52+
} else {
53+
List<TestRunDto> testRuns = mapper.mapObjects(TestRunDto.class, requestedJson);
54+
session.controllerFactory.getHandler(testRuns.get(0)).delete(testRuns);
55+
}
5156
}catch (Exception e) {
5257
handleException(resp, e);
5358
}

0 commit comments

Comments
 (0)