refactor: Address pull request feedback

Author: honzajavorek

packages/fury-adapter-oas3-parser/lib/parser/oas/parseParameterObject.js

@@ -40,8 +40,9 @@ function parseParameterObject(minim, object) {
   const validateIn = R.unless(isValidInValue, createError(minim,
     "'Parameter Object' 'in' must be either 'query, 'header', 'path' or 'cookie'"));
 
+  // FIXME: The following should not be an error
   const ensureInPath = R.unless(hasValue('path'), createError(minim,
-    "Only 'in' values of 'path' is supported at the moment"));
+    "Only 'in' values of 'path' are supported at the moment"));
 
   const parseIn = pipeParseResult(minim,
     parseString(minim, name, true),

packages/fury-adapter-oas3-parser/lib/parser/oas/parsePathItemObject.js

@@ -43,6 +43,7 @@ function extractPathVariables(path) {
 }
 
 function createErrorForMissingPathParameter(minim, path, variable) {
+  // FIXME: This shouldn't be an error
   const message = `Path '${path.toValue()}' contains variable '${variable}' which is not declared in the parameters section of the '${name}'`;
   return createError(minim, message, path);
 }
@@ -60,15 +61,11 @@ function createErrorForMissingPathVariable(minim, path, variable) {
  */
 function validatePathForMissingHrefVariables(minim, path, pathItem) {
   const pathVariables = extractPathVariables(path.toValue());
-
-  let missingParameters;
-
   const hrefVariables = pathItem.get('parameters');
-  if (hrefVariables) {
-    missingParameters = pathVariables.filter(name => !hrefVariables.getMember(name));
-  } else {
-    missingParameters = pathVariables;
-  }
+
+  const missingParameters = hrefVariables
+    ? pathVariables.filter(name => !hrefVariables.getMember(name))
+    : pathVariables;
 
   if (missingParameters.length > 0) {
     const toError = R.curry(createErrorForMissingPathParameter)(minim, path);

packages/fury-adapter-oas3-parser/test/parser/oas/test_parseParameterObject.js

@@ -71,7 +71,7 @@ describe('Parameter Object', () => {
 
       expect(result.length).to.equal(1);
       expect(result.errors.get(0).toValue()).to.equal(
-        "Only 'in' values of 'path' is supported at the moment"
+        "Only 'in' values of 'path' are supported at the moment"
       );
     });
 
@@ -85,7 +85,7 @@ describe('Parameter Object', () => {
 
       expect(result.length).to.equal(1);
       expect(result.errors.get(0).toValue()).to.equal(
-        "Only 'in' values of 'path' is supported at the moment"
+        "Only 'in' values of 'path' are supported at the moment"
       );
     });
 
@@ -99,7 +99,7 @@ describe('Parameter Object', () => {
 
       expect(result.length).to.equal(1);
       expect(result.errors.get(0).toValue()).to.equal(
-        "Only 'in' values of 'path' is supported at the moment"
+        "Only 'in' values of 'path' are supported at the moment"
       );
     });
   });

packages/fury-adapter-oas3-parser/test/pipeParseResult-test.js

@@ -21,7 +21,7 @@ describe('#pipeParseResult', () => {
     expect(parseResult.toValue()).to.deep.equal([10]);
   });
 
-  it('streads multiple elements as arguments during pipe', () => {
+  it('spreads multiple elements as arguments during pipe', () => {
     const duplicate = element => new minim.elements.ParseResult([element, element]);
     const multiply = (lhs, rhs) => lhs.toValue() * rhs.toValue();
     const parse = pipeParseResult(minim,