Badly formatted status msg in AbstractDriverManagerConnectionSource

[RichMacDonald]

Version 2.24.3 org.apache.logging.log4j.core.appender.db.jdbc.AbstractDriverManagerConnectionSource line 162 has a method

        LOGGER.debug(
                "{} acquired connection for '{}': {} ({}{@})",
                getClass().getSimpleName(),
                actualConnectionString,
                connection,
                connection.getClass().getName(),
                Integer.toHexString(connection.hashCode()));

That eventually causes org.apache.logging.log4j.message.ParameterFormatter line 252 to trigger:

                STATUS_LOGGER.warn(
                        "found {} argument placeholders, but provided {} for pattern `{}`",
                        analysis.placeholderCount,
                        argCount,
                        pattern);

Log4j2-TF-12-AsyncLoggerConfig-8 WARN found 4 argument placeholders, but provided 5 for pattern `{} acquired connection for '{}': {} ({}{@})`

In practice, this makes logging to JDBC impractical unless status logging level is set to ERROR. Note that the code is the same in the latest (as of today) release of version 2.

Log4j version 3 has refactored the classes so I don't know if the issue persists.

[ppkarwasz]

Hi @RichMacDonald — great catch! 💯

This issue has actually been present since version 2.22.0 (commit 4c53356), so thank you for spotting it.

I’ve opened issue #3828 to track it — PRs are very welcome!

[vy]

@RichMacDonald, the fix is in 2.x and should be shipped with the next Log4j release, which probably will be, 2.26.0.