Skip to content

Enable more DPP Spark SQL tests #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andygrove opened this issue May 14, 2025 · 0 comments
Open

Enable more DPP Spark SQL tests #1739

andygrove opened this issue May 14, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@andygrove
Copy link
Member

andygrove commented May 14, 2025

What is the problem the feature request solves?

The follow Spark SQL tests should now pass because we fall back to Spark for DPP, so we should stop ignoring them. If they still fail then we should file a specific issue with the root cause and link to that.

sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala:    IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala:    IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {
sql/core/src/test/scala/org/apache/spark/sql/execution/RemoveRedundantProjectsSuite.scala:    IgnoreComet("TODO: Support SubqueryBroadcastExec in Comet: #242")) {

Describe the potential solution

Follow the instructions at https://datafusion.apache.org/comet/contributor-guide/spark-sql-tests.html to update the diffs.

Additional context

No response

@andygrove andygrove added enhancement New feature or request good first issue Good for newcomers labels May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant