Skip to content

Card titles do not have the correct possessive form for names ending in "x" #4232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TenType opened this issue Apr 22, 2025 · 0 comments
Open
Labels
bug Something isn't working.

Comments

@TenType
Copy link

TenType commented Apr 22, 2025

Describe the bug

In the GitHub Stats card, users with names ending in "x" do not have the correct possessive form of their name in their titles.

For example, a user with the name Max is displayed as Max' GitHub Stats instead of Max's GitHub Stats.

Expected behavior

Users with names ending in "x" should have a title with apostrophe-s, not just an apostrophe.

Screenshots / Live demo link

Image

Link to Demo

Additional context

Here are the pertinent lines of code that cause this issue:
https://github.com/anuraghazra/github-readme-stats/blob/25a9dabf13dd8891a96be2421b2b0ed98761f504/src/cards/stats-card.js#L257C1-L259C11

Why was "x" included in this case? It is common to omit the "s" for names ending in "s", but I don't see how this makes grammatical sense for names ending in "x".

Sorry if this is pedantic, but this caught the corner of my eye when I was using this project.

@TenType TenType added the bug Something isn't working. label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

1 participant