You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why was "x" included in this case? It is common to omit the "s" for names ending in "s", but I don't see how this makes grammatical sense for names ending in "x".
Sorry if this is pedantic, but this caught the corner of my eye when I was using this project.
The text was updated successfully, but these errors were encountered:
Uh oh!
There was an error while loading. Please reload this page.
Describe the bug
In the GitHub Stats card, users with names ending in "x" do not have the correct possessive form of their name in their titles.
For example, a user with the name
Max
is displayed asMax' GitHub Stats
instead ofMax's GitHub Stats
.Expected behavior
Users with names ending in "x" should have a title with apostrophe-s, not just an apostrophe.
Screenshots / Live demo link
Link to Demo
Additional context
Here are the pertinent lines of code that cause this issue:
https://github.com/anuraghazra/github-readme-stats/blob/25a9dabf13dd8891a96be2421b2b0ed98761f504/src/cards/stats-card.js#L257C1-L259C11
Why was "x" included in this case? It is common to omit the "s" for names ending in "s", but I don't see how this makes grammatical sense for names ending in "x".
Sorry if this is pedantic, but this caught the corner of my eye when I was using this project.
The text was updated successfully, but these errors were encountered: