Skip to content

Commit b57ac63

Browse files
ygorshkovygorshkov
andauthored
Fix a bug in BaseDimensions.ToString() (#1431)
Current implementation of `AppendDimensionString` ignores value `-1`. This PR fixes the bug. --------- Co-authored-by: ygorshkov <[email protected]>
1 parent 5f0f22d commit b57ac63

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

UnitsNet.Tests/BaseDimensionsTests.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -695,7 +695,13 @@ public void CheckBaseDimensionMultiplicationWithForceEqualsMassTimesAcceleration
695695
[Fact]
696696
public void CheckToStringUsingMolarEntropy()
697697
{
698-
Assert.Equal("[Length]^2[Mass][Time]^-2[Temperature][Amount]", MolarEntropy.BaseDimensions.ToString());
698+
Assert.Equal("[Length]^2[Mass][Time]^-2[Temperature]^-1[Amount]^-1", MolarEntropy.BaseDimensions.ToString());
699+
}
700+
701+
[Fact]
702+
public void CheckToStringUsingSpeed()
703+
{
704+
Assert.Equal("[Length][Time]^-1", Speed.BaseDimensions.ToString());
699705
}
700706

701707
[Fact]

UnitsNet/BaseDimensions.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,13 +182,11 @@ public override string ToString()
182182

183183
private static void AppendDimensionString(StringBuilder sb, string name, int value)
184184
{
185-
var absoluteValue = Math.Abs(value);
186-
187-
if(absoluteValue > 0)
185+
if (0 != value)
188186
{
189187
sb.AppendFormat("[{0}]", name);
190188

191-
if(absoluteValue > 1)
189+
if (1 != value)
192190
sb.AppendFormat("^{0}", value);
193191
}
194192
}

0 commit comments

Comments
 (0)