fix: ng update showing packages that do not exist in my package

alan-agius4 · alan-agius4 · commit 08657f922099 · 2020-03-09T16:01:23.000+01:00
By default if no `packageGroupName` is provided `ng-update` will use the first item in `packageGroup` which in this case it is always `@nguniversal/aspnetcore-engine`. With this change we set the `packageGroupName` of each package, also we remove `ng-update` from `@nguniversal/builders` as this gets updated when running `ng update` on `@nguniversal/express-engine` or `@nguniversal/hapi-engine`. Closes #1542 and closes #1533
diff --git a/modules/aspnetcore-engine/package.json b/modules/aspnetcore-engine/package.json
@@ -26,7 +26,8 @@
     "tslib": "TSLIB_VERSION"
   },
   "ng-update": {
-    "packageGroup": "NG_UPDATE_PACKAGE_GROUP"
+    "packageGroup": "NG_UPDATE_PACKAGE_GROUP",
+    "packageGroupName": "@nguniversal/aspnetcore-engine"
   },
   "repository": {
     "type": "git",
diff --git a/modules/builders/package.json b/modules/builders/package.json
@@ -21,8 +21,5 @@
     "rxjs": "RXJS_VERSION",
     "tree-kill": "^1.2.1",
     "guess-parser": "^0.4.12"
-  },
-  "ng-update": {
-    "packageGroup": "NG_UPDATE_PACKAGE_GROUP"
   }
 }
diff --git a/modules/common/package.json b/modules/common/package.json
@@ -16,7 +16,8 @@
     "tslib": "TSLIB_VERSION"
   },
   "ng-update": {
-    "packageGroup": "NG_UPDATE_PACKAGE_GROUP"
+    "packageGroup": "NG_UPDATE_PACKAGE_GROUP",
+    "packageGroupName": "@nguniversal/common"
   },
   "repository": {
     "type": "git",
diff --git a/modules/express-engine/package.json b/modules/express-engine/package.json
@@ -24,7 +24,8 @@
   "schematics": "./schematics/collection.json",
   "ng-update": {
     "migrations": "./schematics/migrations/migration-collection.json",
-    "packageGroup": "NG_UPDATE_PACKAGE_GROUP"
+    "packageGroup": "NG_UPDATE_PACKAGE_GROUP",
+    "packageGroupName": "@nguniversal/express-engine"
   },
   "repository": {
     "type": "git",
diff --git a/modules/hapi-engine/package.json b/modules/hapi-engine/package.json
@@ -24,7 +24,8 @@
   "schematics": "./schematics/collection.json",
   "ng-update": {
     "migrations": "./schematics/migrations/migration-collection.json",
-    "packageGroup": "NG_UPDATE_PACKAGE_GROUP"
+    "packageGroup": "NG_UPDATE_PACKAGE_GROUP",
+    "packageGroupName": "@nguniversal/hapi-engine"
   },
   "repository": {
     "type": "git",
diff --git a/modules/socket-engine/package.json b/modules/socket-engine/package.json
@@ -17,7 +17,8 @@
     "tslib": "TSLIB_VERSION"
   },
   "ng-update": {
-    "packageGroup": "NG_UPDATE_PACKAGE_GROUP"
+    "packageGroup": "NG_UPDATE_PACKAGE_GROUP",
+    "packageGroupName": "@nguniversal/socket-engine"
   },
   "repository": {
     "type": "git",

Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,5 @@`
`21`	`21`	`"rxjs": "RXJS_VERSION",`
`22`	`22`	`"tree-kill": "^1.2.1",`
`23`	`23`	`"guess-parser": "^0.4.12"`
`24`		`- },`
`25`		`- "ng-update": {`
`26`		`- "packageGroup": "NG_UPDATE_PACKAGE_GROUP"`
`27`	`24`	`}`
`28`	`25`	`}`